[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v13 6/9] gfxstream + rutabaga: add initial support for gfxstr
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v13 6/9] gfxstream + rutabaga: add initial support for gfxstream |
|
Date: |
Wed, 27 Sep 2023 14:24:08 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Thomas Huth <thuth@redhat.com> writes:
[...]
>> +static Property virtio_gpu_rutabaga_properties[] = {
>> + DEFINE_PROP_STRING("capset_names", VirtIOGPURutabaga, capset_names),
>> + DEFINE_PROP_STRING("wayland_socket_path", VirtIOGPURutabaga,
>> + wayland_socket_path),
>
> FWIW, it seems to be more common to use "-" instead of "_" to separate words
> in properties ... so I'd like to suggest to replace the underscores in the
> strings here.
Please separate words with '-', not '_', except where existing
properties all use '_'.