[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/13] ui/vnc: Require audiodev= to enable audio
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 01/13] ui/vnc: Require audiodev= to enable audio |
Date: |
Thu, 28 Sep 2023 09:15:06 +0100 |
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Thu, Sep 28, 2023 at 09:36:45AM +0200, Paolo Bonzini wrote:
> If there is no audiodev do not send the audio ack in response to
> VNC_ENCODING_AUDIO, so that clients aren't told audio exists, and
> immediately drop the client if they try to send any audio control messages
> when audio is not advertised.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> docs/about/deprecated.rst | 8 +++-----
> docs/about/removed-features.rst | 6 ++++++
> ui/vnc.c | 11 ++++++++++-
> ui/vnc.h | 2 ++
> 4 files changed, 21 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v2 00/13] Cleanup deprecated audio features, take 2, Paolo Bonzini, 2023/09/28
- [PATCH 02/13] audio: Require AudioState in AUD_add_capture, Paolo Bonzini, 2023/09/28
- [PATCH 03/13] audio: allow returning an error from the driver init, Paolo Bonzini, 2023/09/28
- [PATCH 01/13] ui/vnc: Require audiodev= to enable audio, Paolo Bonzini, 2023/09/28
- Re: [PATCH 01/13] ui/vnc: Require audiodev= to enable audio,
Daniel P . Berrangé <=
- [PATCH 04/13] audio: return Error ** from audio_state_by_name, Paolo Bonzini, 2023/09/28
- [PATCH 05/13] audio: commonize voice initialization, Paolo Bonzini, 2023/09/28
- [PATCH 06/13] audio: simplify flow in audio_init, Paolo Bonzini, 2023/09/28
- [PATCH 08/13] Introduce machine property "audiodev", Paolo Bonzini, 2023/09/28
- [PATCH 07/13] audio: remove QEMU_AUDIO_* and -audio-help support, Paolo Bonzini, 2023/09/28
- [PATCH 10/13] hw/ppc: Support machine-default audiodev with fallback, Paolo Bonzini, 2023/09/28
- [PATCH 09/13] hw/arm: Support machine-default audiodev with fallback, Paolo Bonzini, 2023/09/28
- [PATCH 11/13] vt82c686: Support machine-default audiodev with fallback, Paolo Bonzini, 2023/09/28
- [PATCH 13/13] audio: forbid default audiodev backend with -nodefaults, Paolo Bonzini, 2023/09/28