Re: [PATCH] hw/acpi: changes towards enabling -Wshadow=local

[Ani Sinha]

> On 29-Sep-2023, at 1:32 PM, Markus Armbruster <armbru@redhat.com> wrote:
> 
> Ani Sinha <anisinha@redhat.com> writes:
> 
>>> On 29-Sep-2023, at 11:43 AM, Markus Armbruster <armbru@redhat.com> wrote:
>>> 
>>> Ani Sinha <anisinha@redhat.com> writes:
>>> 
>>>>> On 29-Sep-2023, at 11:17 AM, Markus Armbruster <armbru@redhat.com> wrote:
>>>>> 
>>>>> Ani Sinha <anisinha@redhat.com> writes:
>>>>> 
>>>>>> Code changes in acpi that addresses all compiler complaints coming from 
>>>>>> enabling
>>>>>> -Wshadow flags. Enabling -Wshadow catches cases of local variables 
>>>>>> shadowing
>>>>>> other local variables or parameters. These makes the code confusing 
>>>>>> and/or adds
>>>>>> bugs that are difficult to catch.
>>>>>> 
>>>>>> The code is tested to build with and without the flag turned on.
>>>>>> 
>>>>>> CC: Markus Armbruster <armbru@redhat.com>
>>>>>> CC: Philippe Mathieu-Daude <philmd@linaro.org>
>>>>>> CC: mst@redhat.com
>>>>>> CC: imammedo@redhat.com
>>>>>> Message-Id: <87r0mqlf9x.fsf@pond.sub.org>
>>>>> 
>>>>> This is my "Help wanted for enabling -Wshadow=local" post.
>>>> 
>>>> Yes indeed. I wanted to refer to that thread for context in the commit log.
>>> 
>>> I appreciate your diligence.  We just don't have an established tag
>>> convention for "see also" references to e-mail.  I could append
>>> 
>>>   See also
>>> 
>>>       Subject: Help wanted for enabling -Wshadow=local
>>>       Message-Id: <87r0mqlf9x.fsf@pond.sub.org>
>>>       87r0mqlf9x.fsf@pond.sub.org">https://lore.kernel.org/qemu-devel/87r0mqlf9x.fsf@pond.sub.org
>>> 
>>> to your first paragraph.  Want me to?
>> 
>> Sure, if that is ok.
> 
> Done!

Your shadow-next has no changes. Have you not pushed to that branch?