[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 9/9] hw/arm/pxa2xx: Realize PXA2XX_I2C device before accessing
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v3 9/9] hw/arm/pxa2xx: Realize PXA2XX_I2C device before accessing it |
Date: |
Fri, 20 Oct 2023 15:03:30 +0200 |
qbus_new(), called in i2c_init_bus(), should not be called
on unrealized device.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/arm/pxa2xx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c
index 601ddd8766..f0bf407e66 100644
--- a/hw/arm/pxa2xx.c
+++ b/hw/arm/pxa2xx.c
@@ -1513,14 +1513,15 @@ PXA2xxI2CState *pxa2xx_i2c_init(hwaddr base,
qdev_prop_set_uint32(dev, "size", region_size + 1);
qdev_prop_set_uint32(dev, "offset", base & region_size);
+ /* FIXME: Should the slave device really be on a separate bus? */
+ i2cbus = i2c_init_bus(dev, "dummy");
+
i2c_dev = SYS_BUS_DEVICE(dev);
sysbus_realize_and_unref(i2c_dev, &error_fatal);
sysbus_mmio_map(i2c_dev, 0, base & ~region_size);
sysbus_connect_irq(i2c_dev, 0, irq);
s = PXA2XX_I2C(i2c_dev);
- /* FIXME: Should the slave device really be on a separate bus? */
- i2cbus = i2c_init_bus(dev, "dummy");
s->slave = PXA2XX_I2C_SLAVE(i2c_slave_create_simple(i2cbus,
TYPE_PXA2XX_I2C_SLAVE,
0));
--
2.41.0
- [PATCH v3 1/9] hw/sd/pxa2xx: Realize sysbus device before accessing it, (continued)
- [PATCH v3 1/9] hw/sd/pxa2xx: Realize sysbus device before accessing it, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 2/9] hw/sd/pxa2xx: Do not open-code sysbus_create_simple(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 3/9] hw/pcmcia/pxa2xx: Realize sysbus device before accessing it, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 4/9] hw/pcmcia/pxa2xx: Do not open-code sysbus_create_simple(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 5/9] hw/pcmcia/pxa2xx: Inline pxa2xx_pcmcia_init(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 7/9] hw/intc/pxa2xx: Pass CPU reference using QOM link property, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 6/9] hw/intc/pxa2xx: Convert to Resettable interface, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 8/9] hw/intc/pxa2xx: Factor pxa2xx_pic_realize() out of pxa2xx_pic_init(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 9/9] hw/arm/pxa2xx: Realize PXA2XX_I2C device before accessing it,
Philippe Mathieu-Daudé <=
- Re: [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes, Richard Henderson, 2023/10/21
- Re: [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes, Peter Maydell, 2023/10/27