Re: [PATCH 33/33] include/exec: Change cpu_mmu

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUStat

From:	Richard Henderson
Subject:	Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState
Date:	Tue, 30 Jan 2024 21:05:28 +1000
User-agent:	Mozilla Thunderbird

On 1/30/24 18:26, Philippe Mathieu-Daudé wrote:

What is the rationale here? (I'm trying to generically understand
in which case one is better than another).


Didn't you ask Anton why a generic cpu_* function was using CPUArchState?

Anyway, I think we've generally used CPUState more often with generic functions, and thisshould follow.

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 27/33] target/s390x: Populate CPUClass.mmu_index, (continued)
- [PATCH 27/33] target/s390x: Populate CPUClass.mmu_index, Richard Henderson, 2024/01/29
- [PATCH 28/33] target/sh4: Populate CPUClass.mmu_index, Richard Henderson, 2024/01/29
- [PATCH 29/33] target/sparc: Populate CPUClass.mmu_index, Richard Henderson, 2024/01/29
- [PATCH 32/33] include/exec: Implement cpu_mmu_index generically, Richard Henderson, 2024/01/29
  - Re: [PATCH 32/33] include/exec: Implement cpu_mmu_index generically, Philippe Mathieu-Daudé, 2024/01/30
- [PATCH 30/33] target/tricore: Populate CPUClass.mmu_index, Richard Henderson, 2024/01/29
- [PATCH 26/33] target/s390x: Split out s390x_env_mmu_index, Richard Henderson, 2024/01/29
- [PATCH 31/33] target/xtensa: Populate CPUClass.mmu_index, Richard Henderson, 2024/01/29
- [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState, Richard Henderson, 2024/01/29
  - Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState, Philippe Mathieu-Daudé, 2024/01/30
    - Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState, Richard Henderson <=
    - Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState, Philippe Mathieu-Daudé, 2024/01/30
- Re: [PATCH 00/33] hw/core: Introduce CPUClass hook for mmu_index, Philippe Mathieu-Daudé, 2024/01/30
- Re: [PATCH 00/33] hw/core: Introduce CPUClass hook for mmu_index, Anton Johansson, 2024/01/30

Prev by Date: Re: [PATCH 01/33] include/hw/core: Add mmu_index to CPUClass
Next by Date: [PATCH] target/riscv: Use RISCVException as return type for all csr ops
Previous by thread: Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState
Next by thread: Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState
Index(es):
- Date
- Thread