Re: [PATCH 02/10] hw/i386/pc: Do pc_cmos_init_late() from pc_machine_done()

[Richard Henderson]

On 2/20/24 06:06, Peter Maydell wrote:
> -static void pc_cmos_init_late(void *opaque)
> +static void pc_cmos_init_late(PCMachineState *pcms)
>   {
> -    pc_cmos_init_late_arg *arg = opaque;
> -    MC146818RtcState *s = arg->rtc_state;
> +    X86MachineState *x86ms = X86_MACHINE(pcms);

We've already done the X86_MACHINE resolution in pc_machine_done -- why not 
just pass it in?

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~