[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 39/39] linux-user: Remove pgb_dynamic alignment assertion
From: |
Richard Henderson |
Subject: |
[PULL 39/39] linux-user: Remove pgb_dynamic alignment assertion |
Date: |
Thu, 22 Feb 2024 10:43:23 -1000 |
The assertion was never correct, because the alignment is a composite
of the image alignment and SHMLBA. Even if the image alignment didn't
match the image address, an assertion would not be correct -- more
appropriate would be an error message about an ill formed image. But
the image cannot be held to SHMLBA under any circumstances.
Fixes: ee94743034b ("linux-user: completely re-write init_guest_space")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2157
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reported-by: Alexey Sheplyakov <asheplyakov@yandex.ru>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
linux-user/elfload.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index f3f1ab4f69..d92d66ca1e 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -3022,8 +3022,6 @@ static void pgb_dynamic(const char *image_name, uintptr_t
guest_loaddr,
uintptr_t brk, ret;
PGBAddrs ga;
- assert(QEMU_IS_ALIGNED(guest_loaddr, align));
-
/* Try the identity map first. */
if (pgb_addr_set(&ga, guest_loaddr, guest_hiaddr, true)) {
brk = (uintptr_t)sbrk(0);
--
2.34.1
- [PULL 30/39] tests/tcg: Extend file in linux-madvise.c, (continued)
- [PULL 30/39] tests/tcg: Extend file in linux-madvise.c, Richard Henderson, 2024/02/22
- [PULL 29/39] tests/tcg: Remove run-test-mmap-*, Richard Henderson, 2024/02/22
- [PULL 31/39] *-user: Deprecate and disable -p pagesize, Richard Henderson, 2024/02/22
- [PULL 32/39] cpu: Remove page_size_init, Richard Henderson, 2024/02/22
- [PULL 33/39] accel/tcg: Disconnect TargetPageDataNode from page size, Richard Henderson, 2024/02/22
- [PULL 34/39] linux-user: Allow TARGET_PAGE_BITS_VARY, Richard Henderson, 2024/02/22
- [PULL 35/39] target/arm: Enable TARGET_PAGE_BITS_VARY for AArch64 user-only, Richard Henderson, 2024/02/22
- [PULL 36/39] linux-user: Bound mmap_min_addr by host page size, Richard Henderson, 2024/02/22
- [PULL 37/39] target/ppc: Enable TARGET_PAGE_BITS_VARY for user-only, Richard Henderson, 2024/02/22
- [PULL 38/39] target/alpha: Enable TARGET_PAGE_BITS_VARY for user-only, Richard Henderson, 2024/02/22
- [PULL 39/39] linux-user: Remove pgb_dynamic alignment assertion,
Richard Henderson <=
- Re: [PULL 00/39] tcg and linux-user patch queue, Peter Maydell, 2024/02/23