[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 0/4] Trivial patches for 2024-04-02
From: |
Peter Maydell |
Subject: |
Re: [PULL 0/4] Trivial patches for 2024-04-02 |
Date: |
Tue, 2 Apr 2024 12:41:05 +0100 |
On Tue, 2 Apr 2024 at 11:41, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
>
> > Author: Stefan Weil via <qemu-trivial@nongnu.org>
>
> *SIGH* This happened *again*.
>
> > (you'll need to tell git log "--no-mailmap" to not get confused
> > by the mapping we have for the last time one of these slipped
> > through...)
>
> Now this is interesting. And this is exactly why I haven't noticed
> it - I did pay attention to Author lines this time. -- because
> it is displayed with mailmap applied. How very useful.
>
> I have to use `git show --no-mailmap' to see the original " via.."
> version.
FWIW my apply-pullreq script makes this check for this:
if git shortlog --author='qemu-.*@nongnu\.org' master..staging | grep .; then
echo "ERROR: pull request includes commits attributed to list"
exit 1
fi
(This doesn't pass --no-mailmap, because git shortlog doesn't
take that option, and the --author match is done on the "true"
author, not the mapped one. This is the kind of orthogonality
in command line UI that we have come to expect from git ;-))
-- PMM
- [PULL 0/4] Trivial patches for 2024-04-02, Michael Tokarev, 2024/04/02
- [PULL 1/4] usb-audio: Fix invalid values in AudioControl descriptors, Michael Tokarev, 2024/04/02
- [PULL 2/4] fpu/softfloat: Remove mention of TILE-Gx target, Michael Tokarev, 2024/04/02
- [PULL 3/4] Fix some typos in documentation (found by codespell), Michael Tokarev, 2024/04/02
- [PULL 4/4] hmp: Add help information for watchdog action: inject-nmi, Michael Tokarev, 2024/04/02
- Re: [PULL 0/4] Trivial patches for 2024-04-02, Peter Maydell, 2024/04/02