[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/7] vga: do not treat horiz pel panning value of 8 as "enabled"
From: |
Paolo Bonzini |
Subject: |
[PULL 4/7] vga: do not treat horiz pel panning value of 8 as "enabled" |
Date: |
Tue, 2 Apr 2024 15:16:46 +0200 |
Horizontal pel panning bit 3 is only used in text mode. In graphics
mode, it can be treated as if it was zero, thus not extending the
dirty memory region.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/display/vga.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/display/vga.c b/hw/display/vga.c
index 40acd19e72a..77f59e8c113 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -1571,7 +1571,9 @@ static void vga_draw_graphic(VGACommonState *s, int
full_update)
break;
}
}
- hpel = bits <= 8 ? s->params.hpel : 0;
+
+ /* Horizontal pel panning bit 3 is only used in text mode. */
+ hpel = bits <= 8 ? s->params.hpel & 7 : 0;
region_start = (s->params.start_addr * 4);
region_end = region_start + (ram_addr_t)s->params.line_offset * height;
--
2.44.0
- [PULL 0/7] lsi, vga fixes for 2024-04-02, Paolo Bonzini, 2024/04/02
- [PULL 4/7] vga: do not treat horiz pel panning value of 8 as "enabled",
Paolo Bonzini <=
- [PULL 5/7] lsi53c895a: avoid out of bounds access to s->msg[], Paolo Bonzini, 2024/04/02
- [PULL 1/7] vga: merge conditionals on shift control register, Paolo Bonzini, 2024/04/02
- [PULL 7/7] pc_q35: remove unnecessary m->alias assignment, Paolo Bonzini, 2024/04/02
- [PULL 6/7] lsi53c895a: detect invalid Block Move instruction, Paolo Bonzini, 2024/04/02
- [PULL 3/7] vga: adjust dirty memory region if pel panning is active, Paolo Bonzini, 2024/04/02
- [PULL 2/7] vga: move computation of dirty memory region later, Paolo Bonzini, 2024/04/02
- Re: [PULL 0/7] lsi, vga fixes for 2024-04-02, Peter Maydell, 2024/04/02