Re: [PATCH] edk2: get version + date from git submodule

[Peter Maydell]

On Mon, 25 Mar 2024 at 14:45, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Turned out hard-coding version and date in the Makefile wasn't a bright
> idea.  Updating it on edk2 updates is easily forgotten.  Fetch the info
> from git instead.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  roms/Makefile | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/roms/Makefile b/roms/Makefile
> index edc234a0e886..534eba17ebd0 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -51,6 +51,8 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
>  # efi ia32, efi x64) into a single rom binary.
>  #
>  EDK2_EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
> +EDK2_STABLE = $(shell cd edk2; git describe --tags --match 'edk2-stable*')
> +EDK2_DATE = $(shell cd edk2; git show --pretty='format:%cd' 
> --date='format:%m/%d/%Y'| head -1)
>
>  default help:
>         @echo "nothing is build by default"
> @@ -149,8 +151,9 @@ skiboot:
>
>  efi:
>         $(PYTHON) edk2-build.py --config edk2-build.config \
> -               --version-override "edk2-stable202302-for-qemu" \
> -               --release-date "03/01/2023"
> +               --version-override "$(EDK2_STABLE)-for-qemu" \
> +               --release-date "$(EDK2_DATE)" \
> +               --silent --no-logs
>         rm -f ../pc-bios/edk2-*.fd.bz2
>         bzip2 --verbose ../pc-bios/edk2-*.fd

Hi -- I've just noticed that we never made this change to
automate the date/version for EDK2 ROMs, but we also never
updated the version by hand. So at the moment we ship an
EDK2 blob that wrongly claims to be an older version.
See this bug report by a user:

https://gitlab.com/qemu-project/qemu/-/issues/2233

Is it possible to fix this for 9.0?

thanks
-- PMM