[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use
From: |
Peter Xu |
Subject: |
Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax" |
Date: |
Thu, 11 Apr 2024 14:42:10 -0400 |
On Thu, Apr 11, 2024 at 11:31:08PM +0530, Het Gala wrote:
> I just wanted to highlight couple of pointers:
> 1. though we are using 'channels' in the precopy tests for 'migrate' QAPI,
> we
> use the old uri for 'migrate-incoming' QAPI.
> 2. We do not cover other 'channels' abi, only have tcp path tested.
>
> So, the TO-DOs could be:
> 1. Omit the 4th patch here, which introduced postcopy qtests with 'channels'
> interface OR have 'channels' interface with other than tcp transport
> (file, exec, vsock, etc) so as to cover different code paths.
> 2. Extend channels interface to migrate-incoming QAPI for precopy qtests
You can see whether Fabiano has anything to say, but what you proposed
looks good to me.
Thanks!
--
Peter Xu
- Re: [PATCH 2/4] tests/qtest/migration: Replace 'migrate-incoming' qtest_qmp_assert_success with migrate_incoming_qmp, (continued)
- [PATCH 4/4] tests/qtest/migration: Add postcopy migration qtests to use 'channels' argument instead of uri, Het Gala, 2024/04/10
- [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Het Gala, 2024/04/10
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Fabiano Rosas, 2024/04/10
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Peter Xu, 2024/04/10
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Het Gala, 2024/04/11
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Peter Xu, 2024/04/11
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Het Gala, 2024/04/11
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax",
Peter Xu <=
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Fabiano Rosas, 2024/04/11
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Peter Xu, 2024/04/12
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Fabiano Rosas, 2024/04/12
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Peter Xu, 2024/04/12
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Het Gala, 2024/04/11