[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/qtest : Use `g_assert_cmphex` instead of `g_assert_cmp
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] tests/qtest : Use `g_assert_cmphex` instead of `g_assert_cmpuint` |
|
Date: |
Sun, 14 Apr 2024 18:19:04 +0200 |
|
User-agent: |
Mozilla Thunderbird |
Hi Inès,
On 14/4/24 15:24, Inès Varhol wrote:
The messages for STM32L4x5 tests will be easier to understand with
`g_assert_cmphex` since the comparisions were made with hexadecimal
"comparisons"
numbers.
Signed-off-by: Inès Varhol <ines.varhol@telecom-paris.fr>
---
tests/qtest/stm32l4x5_exti-test.c | 138 ++++++++++++++--------------
tests/qtest/stm32l4x5_syscfg-test.c | 74 +++++++--------
2 files changed, 106 insertions(+), 106 deletions(-)
$ git grep g_assert_cmpuint.*,\ 0x tests/qtest/stm32*| wc -l
105
Nice cleanup!
$ git grep g_assert_cmpuint.*,\ 0x | wc -l
148
Still 33 to go... (not asking you to do it!).
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>