[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 2/6] ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v10 2/6] ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and helpers |
Date: |
Tue, 23 Apr 2024 14:55:41 +0100 |
User-agent: |
Mutt/2.2.12 (2023-09-09) |
On Mon, Apr 22, 2024 at 07:22:49PM -0700, dongwon.kim@intel.com wrote:
> From: Dongwon Kim <dongwon.kim@intel.com>
>
> New header and source files are added for containing QemuDmaBuf struct
> definition and newly introduced helpers for creating/freeing the struct
> and accessing its data.
>
> v10: Change the license type for both dmabuf.h and dmabuf.c from MIT to
> GPL to be in line with QEMU's default license
> (Daniel P. Berrangé <berrange@redhat.com>)
FYI, in future, notes about changes made in each version would
best go after the '---', since they're not something we need to
record in the commit message once merged. Don't re-send the series
now just for that reason though - whomever merges can trim this.
>
> Suggested-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Cc: Vivek Kasireddy <vivek.kasireddy@intel.com>
> Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
> ---
> include/ui/console.h | 20 +----
> include/ui/dmabuf.h | 64 +++++++++++++++
> ui/dmabuf.c | 189 +++++++++++++++++++++++++++++++++++++++++++
> ui/meson.build | 1 +
> 4 files changed, 255 insertions(+), 19 deletions(-)
> create mode 100644 include/ui/dmabuf.h
> create mode 100644 ui/dmabuf.c
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v10 0/6] ui/console: Private QemuDmaBuf struct, dongwon . kim, 2024/04/22
- [PATCH v10 4/6] ui/console: Use qemu_dmabuf_set_..() helpers instead, dongwon . kim, 2024/04/22
- [PATCH v10 5/6] ui/console: Use qemu_dmabuf_new() and free() helpers instead, dongwon . kim, 2024/04/22
- [PATCH v10 3/6] ui/console: Use qemu_dmabuf_get_..() helpers instead, dongwon . kim, 2024/04/22
- [PATCH v10 6/6] ui/console: move QemuDmaBuf struct def to dmabuf.c, dongwon . kim, 2024/04/22