Re: [PATCH v2] exec: don't use void* in pointer arithmetic in headers

[Paolo Bonzini]

On 6/20/24 22:16, Roman Kiryanov wrote:
> void* pointer arithmetic is a GCC extentension
> which could not be available in other build
> tools (e.g. C++). This changes removes this
> assumption.
>
> Google-Bug-Id: 331190993
> Change-Id: I5a064853429f627c17a9213910811dea4ced6174
> Signed-off-by: Roman Kiryanov <rkir@google.com>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> v2: renamed from "use char* for pointer arithmetic"
>      and removed all explicit extra cast with
>      one typedef in memory.h.
>
>   include/exec/memory.h | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/exec/memory.h b/include/exec/memory.h
> index b1713f30b8..b616338f05 100644
> --- a/include/exec/memory.h
> +++ b/include/exec/memory.h
> @@ -2795,8 +2795,10 @@ MemTxResult address_space_write_rom(AddressSpace *as, 
> hwaddr addr,
>   #define ARG1_DECL    AddressSpace *as
>   #include "exec/memory_ldst_phys.h.inc"
>   
> +typedef uint8_t *MemoryRegionCachePtr;
> +
>   struct MemoryRegionCache {
> -    void *ptr;
> +    MemoryRegionCachePtr ptr;

Just "uint8_t *ptr" is enough; thanks for testing that it's enough.

Queued for the next pull request, thanks.

Paolo


>       hwaddr xlat;
>       hwaddr len;
>       FlatView *fv;