[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v42 76/98] hw/sd/sdcard: Remove noise from sd_acmd_name()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v42 76/98] hw/sd/sdcard: Remove noise from sd_acmd_name() |
Date: |
Fri, 28 Jun 2024 09:01:52 +0200 |
These ACMD names weren't really useful, "UNKNOWN_ACMD" is simpler.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/sd/sd.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 7f93d363c7..19322c558f 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -259,23 +259,13 @@ static const char *sd_cmd_name(SDState *sd, uint8_t cmd)
static const char *sd_acmd_name(SDState *sd, uint8_t cmd)
{
- static const char *acmd_abbrev[SDMMC_CMD_MAX] = {
- [14] = "DPS_spec", [15] = "DPS_spec",
- [16] = "DPS_spec",
- [18] = "SECU_spec",
- [52] = "SECU_spec", [53] = "SECU_spec",
- [54] = "SECU_spec",
- [56] = "SECU_spec", [57] = "SECU_spec",
- [58] = "SECU_spec", [59] = "SECU_spec",
- };
const SDProto *sdp = sd->proto;
if (sdp->acmd[cmd].handler) {
- assert(!acmd_abbrev[cmd]);
return sdp->acmd[cmd].name;
}
- return acmd_abbrev[cmd] ? acmd_abbrev[cmd] : "UNKNOWN_ACMD";
+ return "UNKNOWN_ACMD";
}
static uint8_t sd_get_dat_lines(SDState *sd)
--
2.41.0
- [PATCH v42 70/98] hw/sd/sdcard: Add sd_acmd_SEND_NUM_WR_BLOCKS handler (ACMD22), (continued)
- [PATCH v42 70/98] hw/sd/sdcard: Add sd_acmd_SEND_NUM_WR_BLOCKS handler (ACMD22), Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 72/98] hw/sd/sdcard: Add sd_acmd_SD_APP_OP_COND handler (ACMD41), Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 73/98] hw/sd/sdcard: Add sd_acmd_SET_CLR_CARD_DETECT handler (ACMD42), Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 74/98] hw/sd/sdcard: Add sd_acmd_SEND_SCR handler (ACMD51), Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 75/98] hw/sd/sdcard: Remove sd_none enum from sd_cmd_type_t, Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 76/98] hw/sd/sdcard: Remove noise from sd_acmd_name(),
Philippe Mathieu-Daudé <=
- [PATCH v42 77/98] hw/sd/sdcard: Remove noise from sd_cmd_name(), Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 78/98] hw/sd/sdcard: Remove default case in read/write on DAT lines, Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 79/98] hw/sd/sdcard: Trace length of data read on DAT lines, Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 80/98] hw/sd/sdcard: Introduce set_csd/set_cid handlers, Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 81/98] hw/sd/sdcard: Cover more SDCardStates, Philippe Mathieu-Daudé, 2024/06/28