Re: [PULL 00/34] Migration patches for 2024-09-04

[Peter Maydell]

On Wed, 4 Sept 2024 at 13:49, Fabiano Rosas <farosas@suse.de> wrote:
>
> The following changes since commit e638d685ec2a0700fb9529cbd1b2823ac4120c53:
>
>   Open 9.2 development tree (2024-09-03 09:18:43 -0700)
>
> are available in the Git repository at:
>
>   https://gitlab.com/farosas/qemu.git tags/migration-20240904-pull-request
>
> for you to fetch changes up to d41c9896f49076d1eaaa32214bd2296bd36d866c:
>
>   tests/qtest/migration: Add a check for the availability of the "pc" machine 
> (2024-09-03 16:24:37 -0300)
>
> ----------------------------------------------------------------
> Migration pull request
>
> - Steve's cleanup of unused variable
> - Peter Maydell's fixes for several leaks in migration-test
> - Fabiano's flexibilization of multifd data structures for device
>   state migration
> - Arman Nabiev's fix for ppc e500 migration
> - Thomas' fix for migration-test vs. --without-default-devices

Hi. This generates a bunch of new warning messages when running
"make check":

105/845 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test
           OK             256.17s   51
 subtests passed
――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
stderr:
warning: fd: migration to a file is deprecated. Use file: instead.
warning: fd: migration to a file is deprecated. Use file: instead.
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――

Can you investigate or suppress these, please?

I also see a complaint from the migration-compat-x86_64 job:
https://gitlab.com/qemu-project/qemu/-/jobs/7752621835

Traceback (most recent call last):
File 
"/builds/qemu-project/qemu/build-previous/scripts/vmstate-static-checker.py",
line 438, in <module>
sys.exit(main())
^^^^^^
File 
"/builds/qemu-project/qemu/build-previous/scripts/vmstate-static-checker.py",
line 395, in main
dest_data = json.load(args.dest)
^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.11/json/__init__.py", line 293, in load
return loads(fp.read(),
^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.11/json/__init__.py", line 346, in loads
return _default_decoder.decode(s)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.11/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.11/json/decoder.py", line 353, in raw_decode
obj, end = self.scan_once(s, idx)
^^^^^^^^^^^^^^^^^^^^^^
json.decoder.JSONDecodeError: Unterminated string starting at: line
5085 column 7 (char 131064)
# Failed to run vmstate-static-checker.py
not ok 3 /x86_64/migration/vmstate-checker-script
Bail out!

I think this is probably a pre-existing failure, as
I also saw it on the previous pullreq:
https://gitlab.com/qemu-project/qemu/-/jobs/7751785881

But since this is a migration pullreq, could you have a look?

thanks
-- PMM