|
From: | Brad Smith |
Subject: | Re: [PATCH] tests/functional/qemu_test: Use Python hashlib instead of external programs |
Date: | Fri, 13 Sep 2024 22:30:21 -0400 |
User-agent: | Mozilla Thunderbird |
On 2024-09-10 10:06 p.m., Brian Cain wrote:
On 9/10/2024 5:26 PM, Brad Smith wrote:Rather than port the test to each OS's particular program names, we should use the portable solution that's included w/Python.On 2024-09-10 4:17 p.m., Thomas Huth wrote:Some systems (like OpenBSD) do not have the sha256sum or sha512sum programs installed by default. Use the Python hashlib instead so we don't have torely on the external programs.On OpenBSD they're named sha256 and sha512.
I wasn't trying to imply that the patch wasn't the right direction, it is when it comes portability. Just commenting on what it says in the commit message. This isn't the first time such differences have come up.
[Prev in Thread] | Current Thread | [Next in Thread] |