qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/36] next-cube: remove overlap between next.dma and next.mm


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 03/36] next-cube: remove overlap between next.dma and next.mmio memory regions
Date: Wed, 23 Oct 2024 23:42:21 -0300
User-agent: Mozilla Thunderbird

On 23/10/24 05:58, Mark Cave-Ayland wrote:
Change the start of the next.mmio memory region so that it follows on directly
after the next.dma memory region, adjusting the address offsets in
next_mmio_read() and next_mmio_write() accordingly.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
  hw/m68k/next-cube.c | 28 ++++++++++++++--------------
  1 file changed, 14 insertions(+), 14 deletions(-)


@@ -897,7 +897,7 @@ static void next_pc_realize(DeviceState *dev, Error **errp)
      qdev_init_gpio_in(dev, next_irq, NEXT_NUM_IRQS);
memory_region_init_io(&s->mmiomem, OBJECT(s), &next_mmio_ops, s,
-                          "next.mmio", 0xd0000);
+                          "next.mmio", 0x9000);

Please mention 0xd0000 was incorrect, otherwise:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]