[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] crypto: purge 'loaded' property that was documented as alrea
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH] crypto: purge 'loaded' property that was documented as already removed |
|
Date: |
Mon, 04 Nov 2024 09:09:40 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Daniel P. Berrangé <berrange@redhat.com> writes:
> The 'loaded' property on TLS creds and secret objects was marked as
> deprected in 6.0.0 and then marked as removed in 7.1.0.
deprecated
Regarding "marked as removed": not quite. Its entry was moved from
docs/about/deprecated.rst to docs/about/removed-features.rst, but the
text there is "should simply be removed."
>
> Except it wasn't actually removed, it was just made read-only, while
> claiming it was removed. Finish the long overdue removal job.
>
> Fixes: 0310641c06dd5f7ea031b2b6170cb2edc63e4cea
I'm not sure it fixes something that was broken. Commit 0310641c06d
(crypto: make loaded property read-only) did what it said on the tin.
What it did was unusual, and maybe a bad idea.
Anyway, not important now.
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
- Re: [PATCH] crypto: purge 'loaded' property that was documented as already removed,
Markus Armbruster <=