qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/tcg: Do not use inttypes.h in multiarch/system/memory.


From: Richard Henderson
Subject: Re: [PATCH] tests/tcg: Do not use inttypes.h in multiarch/system/memory.c
Date: Mon, 4 Nov 2024 11:34:21 +0000
User-agent: Mozilla Thunderbird

On 10/29/24 23:29, Ilya Leoshkevich wrote:
On Thu, 2024-10-10 at 11:20 +0200, Paolo Bonzini wrote:
On 10/10/24 10:58, Ilya Leoshkevich wrote:
make check-tcg fails on Fedora with the following error message:

      alpha-linux-gnu-gcc [...]
qemu/tests/tcg/multiarch/system/memory.c -o memory [...]
      qemu/tests/tcg/multiarch/system/memory.c:17:10: fatal error:
inttypes.h: No such file or directory
         17 | #include <inttypes.h>
            |          ^~~~~~~~~~~~
      compilation terminated.

The reason is that Fedora has cross-compilers, but no cross-glibc
headers. Fix by hardcoding the format specifiers and dropping the
include.

An alternative fix would be to introduce a configure check for
inttypes.h. But this would make it impossible to use Fedora
cross-compilers for softmmu tests, which used to work so far.

Fixes: ecbcc9ead2f8 ("tests/tcg: add a system test to check memory
instrumentation")
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

[...]

Thanks for the review!

Could someone please pick this one and also [1] up?
Both patches are aimed at improving the situation with the test builds.

[1]
https://lore.kernel.org/qemu-devel/20241023131250.48510-1-iii@linux.ibm.com/

Queued, thanks.

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]