[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/5] hw/net/lan9118_phy: Fix off-by-one error in MII_ANLPA
|
From: |
Guenter Roeck |
|
Subject: |
Re: [PATCH v3 3/5] hw/net/lan9118_phy: Fix off-by-one error in MII_ANLPAR register |
|
Date: |
Mon, 4 Nov 2024 07:35:51 -0800 |
On Sat, Nov 02, 2024 at 01:57:22PM +0100, Bernhard Beschow wrote:
> Turns 0x70 into 0xe0 (== 0x70 << 1) which adds the missing MII_ANLPAR_TX and
> fixes the MSB of selector field to be zero, as specified in the datasheet.
>
> Fixes: 2a424990170b "LAN9118 emulation"
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
- [PATCH v3 0/5] Consolidate lan9118 phy implementations, Bernhard Beschow, 2024/11/02
- [PATCH v3 1/5] hw/net/lan9118: Extract lan9118_phy, Bernhard Beschow, 2024/11/02
- [PATCH v3 2/5] hw/net/lan9118_phy: Reuse in imx_fec and consolidate implementations, Bernhard Beschow, 2024/11/02
- [PATCH v3 3/5] hw/net/lan9118_phy: Fix off-by-one error in MII_ANLPAR register, Bernhard Beschow, 2024/11/02
- Re: [PATCH v3 3/5] hw/net/lan9118_phy: Fix off-by-one error in MII_ANLPAR register,
Guenter Roeck <=
- [PATCH v3 4/5] hw/net/lan9118_phy: Reuse MII constants, Bernhard Beschow, 2024/11/02
- [PATCH v3 5/5] hw/net/lan9118_phy: Add missing 100 mbps full duplex advertisement, Bernhard Beschow, 2024/11/02