Re: [QEMU PATCH v9] xen/passthrough: use gsi to map pirq when dom0 is PVH

[Stewart Hildebrand]

On 11/4/24 01:03, Chen, Jiqian wrote:
> On 2024/11/1 21:09, Stewart Hildebrand wrote:
>> On 10/24/24 05:06, Jiqian Chen wrote:
>>> diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
>>> index 3635d1b39f79..5b10d501d566 100644
>>> --- a/hw/xen/xen_pt.c
>>> +++ b/hw/xen/xen_pt.c
>>> @@ -766,6 +766,50 @@ static void xen_pt_destroy(PCIDevice *d) {
>>>  }
>>>  /* init */
>>>  
>>> +#if CONFIG_XEN_CTRL_INTERFACE_VERSION >= 42000
>>> +static bool xen_pt_need_gsi(void)
>>> +{
>>> +    FILE *fp;
>>> +    int len;
>>> +    char type[10];
>>
>> A brief in-code comment to explain how you arrived at 10 would be
>> appreciated.
> The max number of characters in the description of the "guest_type" is 4 
> ("PVH" plus line break).
> I set it to 10 to prevent longer description types in the future.
> Do you have another suggest number?

No, I think 10 is a good choice. I'm just looking for the rationale to
be documented.