qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] arm/virt: Extract common code to wire GICC<->vCPU IRQs for r


From: Gavin Shan
Subject: Re: [PATCH] arm/virt: Extract common code to wire GICC<->vCPU IRQs for reuse
Date: Tue, 5 Nov 2024 10:13:42 +1000
User-agent: Mozilla Thunderbird

On 11/4/24 11:26 PM, Peter Maydell wrote:
On Sun, 3 Nov 2024 at 15:25, Salil Mehta <salil.mehta@huawei.com> wrote:

Extract common GIC and CPU interrupt wiring code to improve code
readability and modularity, supporting reuse in future patch sets. This
refactor is benign and introduces *no* functional changes.

Note: This patch has been isolated from a larger patch set to facilitate
early merging and reduce the complexity of the original set, as it
operates independently. All original tags and author contributions are
retained.

I would prefer to see refactoring patches in the context of
the series that makes them necessary. As it stands, there
doesn't really seem to be much benefit to this change.


+1. Please include those 3 (refactoring) patches into a series where
the background is given.

Thanks,
Gavin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]