Re: [PATCH] linux-user: Fix setreuid and setregid to use direct syscalls

[Ilya Leoshkevich]

On Tue, 2024-11-05 at 16:15 +0100, Helge Deller wrote:
> The commit fd6f7798ac30 ("linux-user: Use direct syscalls for
> setuid(),
> etc") added direct syscall wrappers for setuid(), setgid(), etc since
> the
> system calls have different semantics than the libc functions.
> 
> Add and use the corresponding wrappers for setreuid and setregid
> which
> were missed in that commit.
> 
> This fixes the build of the debian package of the uid_wrapper library
> (https://cwrap.org/uid_wrapper.html) when running linux-user.
> 
> Signed-off-by: Helge Deller <deller@gmx.de>

Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>

I should've checked the other syscalls when fixing setgroups recently.
Seems like with this patch, linux-user will no longer call glibc
functions that use INLINE_SETXID_SYSCALL().