RE: [PATCH] Hexagon (target/hexagon) Remove HEX_DEBUG/HEX_DEBUG_LOG

[ltaylorsimpson]

> -----Original Message-----
> From: Brian Cain <quic_bcain@quicinc.com>
> Sent: Monday, November 4, 2024 3:52 PM
> To: Taylor Simpson <ltaylorsimpson@gmail.com>; qemu-devel@nongnu.org
> Cc: bcain@quicinc.com; quic_mathbern@quicinc.com;
> sidneym@quicinc.com; quic_mliebel@quicinc.com;
> richard.henderson@linaro.org; philmd@linaro.org; ale@rev.ng; anjo@rev.ng
> Subject: Re: [PATCH] Hexagon (target/hexagon) Remove
> HEX_DEBUG/HEX_DEBUG_LOG
> 
> 
> On 11/4/2024 11:49 AM, Taylor Simpson wrote:
> > All Hexagon debugging is now done with QEMU mechanisms (e.g., -d
> > in_asm) or with a connected debugger (lldb).
> >
> > Signed-off-by: Taylor Simpson <ltaylorsimpson@gmail.com>
> > ---
> >   target/hexagon/cpu.h       |   8 +--
> >   target/hexagon/helper.h    |   5 +-
> >   target/hexagon/internal.h  |  13 +----
> >   target/hexagon/translate.h |   2 -
> >   target/hexagon/genptr.c    |   9 +--
> >   target/hexagon/op_helper.c | 112 -------------------------------------
> >   target/hexagon/translate.c |  66 ----------------------
> >   target/hexagon/README      |   9 ---
> >   8 files changed, 4 insertions(+), 220 deletions(-)
> >
> > diff --git a/target/hexagon/cpu.h b/target/hexagon/cpu.h index
> > 764f3c38cc..bb7d83b53e 100644
> > --- a/target/hexagon/cpu.h
> > +++ b/target/hexagon/cpu.h
> > @@ -1,5 +1,5 @@
> >   /*
> > - *  Copyright(c) 2019-2023 Qualcomm Innovation Center, Inc. All Rights
> Reserved.
> > + *  Copyright(c) 2019-2024 Qualcomm Innovation Center, Inc. All Rights
> Reserved.
> >    *
> 
> You should not modify the QuIC copyright dates.  But you can add your own
> copyright to these files for this change, if you like.

I'll undo the QuIC copyright changes, but I hardly think removing code warrants 
adding my own copyright.

Thanks,
Taylor