[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 02/11] rust: build: move rustc_args.py invocation to indi
From: |
Junjie Mao |
Subject: |
Re: [RFC PATCH 02/11] rust: build: move rustc_args.py invocation to individual crates |
Date: |
Tue, 12 Nov 2024 11:02:22 +0800 |
User-agent: |
mu4e 1.6.10; emacs 27.1 |
Paolo Bonzini <pbonzini@redhat.com> writes:
> Only qemu-api needs access to the symbols in config-host.h.
This may no longer be the case when more complex, build-time
configurable devices are added in the future.
Moving rustc_args.py calls to each crate is still helpful because of the
changes in patches 3-6 in this series. So I think every crate under
rust/ needs a run_command(rustc_args, ...) for crate-specific arguments.
--
Best Regards
Junjie Mao
> Remove
> the temptation to use them by limiting the --cfg arguments to the
> qemu-api crate.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> meson.build | 54 +++++++++++++++++----------------------
> rust/qemu-api/meson.build | 4 +++
> 2 files changed, 28 insertions(+), 30 deletions(-)