Re: [PATCH 01/10] target/mips: Drop left-over comment about Jazz machine

[Richard Henderson]

On 11/15/24 07:20, Philippe Mathieu-Daudé wrote:
> Commit 3803b6b427 ("target/mips: Fold jazz behaviour into
> mips_cpu_do_transaction_failed") removed update on TCGCPUOps
> and commit 119065574d ("hw/core: Constify TCGCPUOps") made
> it const. Remove the now irrelevant comment.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/mips/cpu.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/target/mips/cpu.c b/target/mips/cpu.c
> index d0a43b6d5c..7c6f438e5d 100644
> --- a/target/mips/cpu.c
> +++ b/target/mips/cpu.c
> @@ -546,10 +546,6 @@ static Property mips_cpu_properties[] = {
>   
>   #ifdef CONFIG_TCG
>   #include "hw/core/tcg-cpu-ops.h"
> -/*
> - * NB: cannot be const, as some elements are changed for specific
> - * mips hardware (see hw/mips/jazz.c).
> - */
>   static const TCGCPUOps mips_tcg_ops = {
>       .initialize = mips_tcg_init,
>       .synchronize_from_tb = mips_cpu_synchronize_from_tb,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~