[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 09/15] tests/functional: put QEMUMachine logs in testcase log dir
From: |
Daniel P . Berrangé |
Subject: |
[PATCH 09/15] tests/functional: put QEMUMachine logs in testcase log directory |
Date: |
Tue, 19 Nov 2024 15:05:13 +0000 |
We are not passing the 'log_dir' parameter to QEMUMachine, so the
QEMU stdout/err logs are being placed in a temp directory and thus
deleted after execution. This makes them inaccessible as gitlab
CI artifacts.
Pass the testcase log directory path into QEMUMachine to make the
logs persistent.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
tests/functional/qemu_test/testcase.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/functional/qemu_test/testcase.py
b/tests/functional/qemu_test/testcase.py
index b9418e2ac0..ca13af244b 100644
--- a/tests/functional/qemu_test/testcase.py
+++ b/tests/functional/qemu_test/testcase.py
@@ -163,10 +163,11 @@ def require_device(self, devicename):
self.skipTest('no support for device ' + devicename)
def _new_vm(self, name, *args):
- vm = QEMUMachine(self.qemu_bin, base_temp_dir=self.workdir)
+ vm = QEMUMachine(self.qemu_bin,
+ base_temp_dir=self.workdir,
+ log_dir=self.logdir)
self.log.debug('QEMUMachine "%s" created', name)
self.log.debug('QEMUMachine "%s" temp_dir: %s', name, vm.temp_dir)
- self.log.debug('QEMUMachine "%s" log_dir: %s', name, vm.log_dir)
if args:
vm.add_args(*args)
return vm
--
2.46.0
- [PATCH 04/15] tests/functional: remove todo wrt avocado.utils.wait_for, (continued)
- [PATCH 04/15] tests/functional: remove todo wrt avocado.utils.wait_for, Daniel P . Berrangé, 2024/11/19
- [PATCH 05/15] tests/functional: remove leftover :avocado: tags, Daniel P . Berrangé, 2024/11/19
- [PATCH 08/15] tests/functional: honour self.workdir in ACPI bits tests, Daniel P . Berrangé, 2024/11/19
- [PATCH 06/15] tests/functional: remove obsolete reference to avocado bug, Daniel P . Berrangé, 2024/11/19
- [PATCH 07/15] tests/functional: remove comments talking about avocado, Daniel P . Berrangé, 2024/11/19
- [PATCH 09/15] tests/functional: put QEMUMachine logs in testcase log directory,
Daniel P . Berrangé <=
- [PATCH 11/15] tests/functional: enable debug logging for QEMUMachine, Daniel P . Berrangé, 2024/11/19
- [PATCH 10/15] tests/functional: honour requested test VM name in QEMUMachine, Daniel P . Berrangé, 2024/11/19
- [PATCH 12/15] tests/functional: logs details of console interaction operations, Daniel P . Berrangé, 2024/11/19
- [PATCH 13/15] tests/functional: rewrite console handling to be bytewise, Daniel P . Berrangé, 2024/11/19