qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] meson.build: Refuse XCode versions < v15.0


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] meson.build: Refuse XCode versions < v15.0
Date: Tue, 26 Nov 2024 09:57:15 +0100
User-agent: Mozilla Thunderbird

On 26/11/24 09:10, Thomas Huth wrote:
According to our support policy, we only support the two latest
major versions of macOS, and we already removed compatibility code
for older versions. However, it's still possible that people install
an older version of XCode on a recent version of macOS - which won't
be able to compile QEMU anymore, see for example the ticket here:

  https://gitlab.com/qemu-project/qemu/-/issues/2694
Wondering about this issue, it is possible to install concurrent
XCode versions, which is useful i.e. when you build an application
targeting multiple (and older) App Store releases. See:
https://xcodereleases.com/

Maybe we need to clarify our support policy that we only support
the XCode released with the 2 latest major macOS versions?

Thus let's set the expectations right and refuse older versions of
XCode that do not match the two latest versions of macOS anymore.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
  meson.build | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meson.build b/meson.build
index e0b880e4e1..a290dbfa33 100644
--- a/meson.build
+++ b/meson.build
@@ -315,8 +315,8 @@ foreach lang : all_languages
      # ok
    elif compiler.get_id() == 'clang' and compiler.compiles('''
        #ifdef __apple_build_version__
-      # if __clang_major__ < 12 || (__clang_major__ == 12 && __clang_minor__ < 
0)
-      #  error You need at least XCode Clang v12.0 to compile QEMU
+      # if __clang_major__ < 15 || (__clang_major__ == 15 && __clang_minor__ < 
0)
+      #  error You need at least XCode Clang v15.0 to compile QEMU
        # endif
        #else
        # if __clang_major__ < 10 || (__clang_major__ == 10 && __clang_minor__ 
< 0)
@@ -325,7 +325,7 @@ foreach lang : all_languages
        #endif''')
      # ok
    else
-    error('You either need GCC v7.4 or Clang v10.0 (or XCode Clang v12.0) to 
compile QEMU')
+    error('You either need GCC v7.4 or Clang v10.0 (or XCode Clang v15.0) to 
compile QEMU')
BTW apparently CentOS 8 (which we don't support anymore IIRC)
provides Clang 12.0.1, and also Ubuntu 22.04, Alpine 3.16.

I wonder if the relation with XCode __apple_build_version__ is
always __clang_major__ + 3...

    endif
  endforeach



reply via email to

[Prev in Thread] Current Thread [Next in Thread]