Re: [PULL 15/42] tests/functional: enable pre-emptive caching of assets

[Daniel P . Berrangé]

On Tue, Nov 26, 2024 at 04:54:18PM -0600, Richard Henderson wrote:
> On 11/26/24 11:52, Thomas Huth wrote:
> > I think we want to continue to maek failing downloads as test failures,
> > otherwise we'll never notice when an asset is not available from the
> > internet anymore (since SKIPs just get ignored).
> 
> I disagree.  Download failures are not rare.

Failures of the test to download assets will be rare *if* we have the
CI runner cache fixed. We only need to successfully download each
asset once, and it should be cached forever with no expiry timeout.

So we have an initially bootstrapping problem once caching is fixed,
where download failures could impact us. Once the cache is primed,
we'll only be at risk of download failures when introducing new
asset URLs, so I think it is fair to say failures should be rare
*if* we get the caching fixed.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|