[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 0/5] support unaligned access to xHCI Capability
From: |
Peter Maydell |
Subject: |
Re: [RFC PATCH 0/5] support unaligned access to xHCI Capability |
Date: |
Wed, 27 Nov 2024 11:23:22 +0000 |
On Wed, 27 Nov 2024 at 04:34, Tomoyuki HIROSE
<tomoyuki.hirose@igel.co.jp> wrote:
>
> I would be happy to receive your comments.
> ping.
Hi; this one is on my to-review list (along, sadly, with 23 other
series); I had a quick look a while back and it seemed good
(the testing support you've added looks great), but I need
to sit down and review the implementation more carefully.
The one concern I did have was the big long list of macro
invocations in the memaccess-testdev device. I wonder if it
would be more readable and more compact to fill in MemoryRegionOps
structs at runtime using loops in C code, rather than trying to do
it all at compile time with macros ?
thanks
-- PMM
- [RFC PATCH 0/5] support unaligned access to xHCI Capability, Tomoyuki HIROSE, 2024/11/07
- [RFC PATCH 1/5] hw/nvme/ctrl: specify the 'valid' field in MemoryRegionOps, Tomoyuki HIROSE, 2024/11/07
- [RFC PATCH 2/5] system/memory: support unaligned access, Tomoyuki HIROSE, 2024/11/07
- [RFC PATCH 3/5] hw/misc: add test device for memory access, Tomoyuki HIROSE, 2024/11/07
- [RFC PATCH 4/5] tests/qtest: add test for memory region access, Tomoyuki HIROSE, 2024/11/07
- [RFC PATCH 5/5] hw/usb/hcd-xhci: allow unaligned access to Capability Registers, Tomoyuki HIROSE, 2024/11/07
- Re: [RFC PATCH 0/5] support unaligned access to xHCI Capability, Tomoyuki HIROSE, 2024/11/26
- Re: [RFC PATCH 0/5] support unaligned access to xHCI Capability,
Peter Maydell <=