Re: [PATCH v4 1/4] hw/s390x: add SCLP event type CPI

[Shalini Chellathurai Saroja]

On 2025-04-29 11:20, Nina Schoetterl-Glausch wrote:
> On Thu, 2025-04-10 at 17:09 +0200, Shalini Chellathurai Saroja wrote:
> > Implement the Service-Call Logical Processor (SCLP) event
> > type Control-Program Identification (CPI) in QEMU. This
> > event is used to send CPI identifiers from the guest to the
> > host. The CPI identifiers are: system type, system name,
> > system level and sysplex name.
> >
> > System type: operating system of the guest (e.g. "LINUX").
> > System name: user configurable name of the guest (e.g. "TESTVM").
> > System level: distribution and kernel version, if the system type is 
> > Linux
> > (e.g. 0x50e00).
> > Sysplex name: name of the cluster which the guest belongs to (if any)
> > (e.g. "PLEX").
> >
> > Signed-off-by: Shalini Chellathurai Saroja <shalini@linux.ibm.com>
> > Reviewed-by: Thomas Huth <thuth@redhat.com>
> > ---
> >  hw/s390x/event-facility.c         |  2 +
> >  hw/s390x/meson.build              |  1 +
> >  hw/s390x/s390-virtio-ccw.c        | 14 +++++
> >  hw/s390x/sclpcpi.c                | 92 
> > +++++++++++++++++++++++++++++++
> >  include/hw/s390x/event-facility.h | 13 +++++
> >  5 files changed, 122 insertions(+)
> >  create mode 100644 hw/s390x/sclpcpi.c
>
> [...]
>
>
> >  static void s390_cpu_plug(HotplugHandler *hotplug_dev,
> > diff --git a/hw/s390x/sclpcpi.c b/hw/s390x/sclpcpi.c
> > new file mode 100644
> > index 0000000000..13589459b1
> > --- /dev/null
> > +++ b/hw/s390x/sclpcpi.c
>
> [...]
>
> > +static void cpi_class_init(ObjectClass *klass, void *data)
>
> Should be 'const void *data'.

Ok, thank you.

> > +{
> > +    DeviceClass *dc = DEVICE_CLASS(klass);
> > +    SCLPEventClass *k = SCLP_EVENT_CLASS(klass);
> > +
> > +    dc->user_creatable = false;
> > +
> > +    k->can_handle_event = can_handle_event;
> > +    k->get_send_mask = send_mask;
> > +    k->get_receive_mask = receive_mask;
> > +    k->write_event_data = write_event_data;
> > +}
>
> [...]

--
Mit freundlichen Grüßen / Kind regards
Shalini Chellathurai Saroja
Software Developer
Linux on IBM Z & KVM Development
IBM Deutschland Research & Development GmbH
Dept 1419, Schoenaicher Str. 220, 71032 Boeblingen
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht 
Stuttgart, HRB 243294