Re: [PATCH v5 41/48] target/arm/tcg/crypto_helper: compile file twice (system, user)

[Richard Henderson]

On 5/5/25 11:47, Pierrick Bouvier wrote:
> On 5/5/25 11:38 AM, Richard Henderson wrote:
> > On 5/4/25 18:52, Pierrick Bouvier wrote:
> > > --- a/target/arm/tcg/meson.build
> > > +++ b/target/arm/tcg/meson.build
> > > @@ -30,7 +30,6 @@ arm_ss.add(files(
> > >      'translate-mve.c',
> > >      'translate-neon.c',
> > >      'translate-vfp.c',
> > > -  'crypto_helper.c',
> > >      'hflags.c',
> > >      'iwmmxt_helper.c',
> > >      'm_helper.c',
> > > @@ -63,3 +62,10 @@ arm_system_ss.add(files(
> > >    arm_system_ss.add(when: 'CONFIG_ARM_V7M', if_true: files('cpu-v7m.c'))
> > >    arm_user_ss.add(when: 'TARGET_AARCH64', if_false: files('cpu-v7m.c'))
> > > +
> > > +arm_common_system_ss.add(files(
> > > +  'crypto_helper.c',
> > > +))
> > > +arm_user_ss.add(files(
> > > +  'crypto_helper.c',
> > > +))
> >
> > Could this use arm_common_ss?  I don't see anything that needs to be built 
> > user/system in
> > this file...
>
> It needs vec_internal.h (clear_tail), which needs CPUARMState, which pulls cpu.h, which 
> uses CONFIG_USER_ONLY.

Ah, right.  I didn't see that coming.  :-)

> I'll take a look to break this dependency, so it can be built only once, and for other 
> files as well.

Thanks.  Building twice is still an improvement, so for this set,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~