[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 5/5] include/hw/boards: add warning about changing deprecation
From: |
Daniel P . Berrangé |
Subject: |
[PATCH v3 5/5] include/hw/boards: add warning about changing deprecation logic |
Date: |
Tue, 6 May 2025 17:00:24 +0100 |
If we change the deprecation logic in include/hw/boards.h, we must make
a corresponding change to docs/conf.py and docs/about/deprecated.rst.
Add comments to these files as a warning to future maintainers to keep
these files in sync.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
docs/conf.py | 4 ++++
include/hw/boards.h | 6 +++++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/docs/conf.py b/docs/conf.py
index 248ff8cf5d..f892a6e1da 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -136,6 +136,10 @@
else:
minor += 1
+# These thresholds must match the constants
+# MACHINE_VER_DELETION_MAJOR & MACHINE_VER_DEPRECATION_MAJOR
+# defined in include/hw/boards.h and the introductory text in
+# docs/about/deprecated.rst
ver_machine_deprecation_version = "%d.%d.0" % (major - 3, minor)
ver_machine_deletion_version = "%d.%d.0" % (major - 6, minor)
diff --git a/include/hw/boards.h b/include/hw/boards.h
index a6784fe984..a7b1fcffae 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -636,7 +636,11 @@ struct MachineState {
/*
* How many years/major releases for each phase
* of the life cycle. Assumes use of versioning
- * scheme where major is bumped each year
+ * scheme where major is bumped each year.
+ *
+ * These values must match the ver_machine_deprecation_version
+ * and ver_machine_deletion_version logic in docs/conf.py and
+ * the text in docs/about/deprecated.rst
*/
#define MACHINE_VER_DELETION_MAJOR 6
#define MACHINE_VER_DEPRECATION_MAJOR 3
--
2.49.0
[PATCH v3 5/5] include/hw/boards: add warning about changing deprecation logic,
Daniel P . Berrangé <=
[PATCH v3 4/5] docs/about/removed-features: auto-generate a note for versioned machine types, Daniel P . Berrangé, 2025/05/06
[PATCH v3 1/5] Revert "include/hw: temporarily disable deletion of versioned machine types", Daniel P . Berrangé, 2025/05/06
[PATCH v3 3/5] docs/about/deprecated: auto-generate a note for versioned machine types, Daniel P . Berrangé, 2025/05/06
Re: [PATCH v3 0/5] docs: automated info about machine deprecation/removal info, Thomas Huth, 2025/05/06
Re: [PATCH v3 0/5] docs: automated info about machine deprecation/removal info, Philippe Mathieu-Daudé, 2025/05/08
Re: [PATCH v3 0/5] docs: automated info about machine deprecation/removal info, Michael S. Tsirkin, 2025/05/09
Re: [PATCH v3 0/5] docs: automated info about machine deprecation/removal info, Michael S. Tsirkin, 2025/05/11