[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 14/24] target/m68k: Remove env argument to gen_load_mode
From: |
Richard Henderson |
Subject: |
[PATCH v5 14/24] target/m68k: Remove env argument to gen_load_mode |
Date: |
Wed, 7 May 2025 14:12:49 -0700 |
Use the env pointer in DisasContext.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/m68k/translate.c | 31 ++++++++++++-------------------
1 file changed, 12 insertions(+), 19 deletions(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index e0482bdbec..ac48329674 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -776,9 +776,8 @@ static TCGv gen_lea(CPUM68KState *env, DisasContext *s,
uint16_t insn,
* a write otherwise it is a read (0 == sign extend, -1 == zero extend).
* ADDRP is non-null for readwrite operands.
*/
-static TCGv gen_load_mode(CPUM68KState *env, DisasContext *s,
- int mode, int reg0, int opsize, TCGv *addrp,
- int sign, int index)
+static TCGv gen_load_mode(DisasContext *s, int mode, int reg0, int opsize,
+ TCGv *addrp, int sign, int index)
{
TCGv reg, ret, addr = NULL;
int32_t offset;
@@ -799,19 +798,19 @@ static TCGv gen_load_mode(CPUM68KState *env, DisasContext
*s,
/* Immediate: sign extend values for consistency. */
switch (opsize) {
case OS_BYTE:
- offset = read_im8(env, s);
+ offset = read_im8(s->env, s);
if (sign) {
offset = (int8_t)offset;
}
break;
case OS_WORD:
- offset = read_im16(env, s);
+ offset = read_im16(s->env, s);
if (sign) {
offset = (int16_t)offset;
}
break;
case OS_LONG:
- offset = read_im32(env, s);
+ offset = read_im32(s->env, s);
break;
default:
g_assert_not_reached();
@@ -1324,7 +1323,7 @@ static void gen_exit_tb(DisasContext *s)
#define SRC_EA(env, result, opsize, op_sign, addrp) \
do { \
- result = gen_load_mode(env, s, extract32(insn, 3, 3), \
+ result = gen_load_mode(s, extract32(insn, 3, 3), \
REG(insn, 0), opsize, addrp, \
op_sign, IS_USER(s)); \
if (IS_NULL_QREG(result)) { \
@@ -1700,10 +1699,8 @@ DISAS_INSN(abcd_mem)
/* Indirect pre-decrement load (mode 4) */
- src = gen_load_mode(env, s, 4, REG(insn, 0), OS_BYTE,
- NULL, false, IS_USER(s));
- dest = gen_load_mode(env, s, 4, REG(insn, 9), OS_BYTE,
- &addr, false, IS_USER(s));
+ src = gen_load_mode(s, 4, REG(insn, 0), OS_BYTE, NULL, false, IS_USER(s));
+ dest = gen_load_mode(s, 4, REG(insn, 9), OS_BYTE, &addr, false,
IS_USER(s));
bcd_add(dest, src);
@@ -1736,10 +1733,8 @@ DISAS_INSN(sbcd_mem)
/* Indirect pre-decrement load (mode 4) */
- src = gen_load_mode(env, s, 4, REG(insn, 0), OS_BYTE,
- NULL, false, IS_USER(s));
- dest = gen_load_mode(env, s, 4, REG(insn, 9), OS_BYTE,
- &addr, false, IS_USER(s));
+ src = gen_load_mode(s, 4, REG(insn, 0), OS_BYTE, NULL, false, IS_USER(s));
+ dest = gen_load_mode(s, 4, REG(insn, 9), OS_BYTE, &addr, false,
IS_USER(s));
bcd_sub(dest, src);
@@ -3120,11 +3115,9 @@ DISAS_INSN(cmpm)
TCGv src, dst;
/* Post-increment load (mode 3) from Ay. */
- src = gen_load_mode(env, s, 3, REG(insn, 0), opsize,
- NULL, true, IS_USER(s));
+ src = gen_load_mode(s, 3, REG(insn, 0), opsize, NULL, true, IS_USER(s));
/* Post-increment load (mode 3) from Ax. */
- dst = gen_load_mode(env, s, 3, REG(insn, 9), opsize,
- NULL, true, IS_USER(s));
+ dst = gen_load_mode(s, 3, REG(insn, 9), opsize, NULL, true, IS_USER(s));
gen_update_cc_cmp(s, dst, src, opsize);
}
--
2.43.0
- [PATCH v5 03/24] target/m68k: Keep FPSR up-to-date, (continued)
- [PATCH v5 03/24] target/m68k: Keep FPSR up-to-date, Richard Henderson, 2025/05/07
- [PATCH v5 06/24] target/m68k: Introduce M68K_FEATURE_FPU_PACKED_DECIMAL, Richard Henderson, 2025/05/07
- [PATCH v5 10/24] target/m68k: Move pre-dec/post-inc to gen_lea_mode, Richard Henderson, 2025/05/07
- [PATCH v5 05/24] target/m68k: Update FPSR for FMOVECR, Richard Henderson, 2025/05/07
- [PATCH v5 12/24] target/m68k: Remove env argument to gen_lea_indexed, Richard Henderson, 2025/05/07
- [PATCH v5 07/24] target/m68k: Merge gen_ea into SRC_EA and DEST_EA, Richard Henderson, 2025/05/07
- [PATCH v5 08/24] target/m68k: Use g_assert_not_reached in gen_lea_mode and gen_ea_mode, Richard Henderson, 2025/05/07
- [PATCH v5 09/24] target/m68k: Use OS_UNSIZED in LEA, PEA, JMP, Richard Henderson, 2025/05/07
- [PATCH v5 13/24] target/m68k: Remove env argument to gen_lea_mode, Richard Henderson, 2025/05/07
- [PATCH v5 11/24] target/m68k: Split gen_ea_mode for load/store, Richard Henderson, 2025/05/07
- [PATCH v5 14/24] target/m68k: Remove env argument to gen_load_mode,
Richard Henderson <=
- [PATCH v5 18/24] target/m68k: Move gen_addr_fault into gen_{load, store}_mode_fp, Richard Henderson, 2025/05/07
- [PATCH v5 20/24] target/m68k: Merge gen_store_fp, gen_store_mode_fp, Richard Henderson, 2025/05/07
- [PATCH v5 21/24] target/m68k: Implement packed decimal real loads and stores, Richard Henderson, 2025/05/07
- [PATCH v5 15/24] target/m68k: Remove env argument to gen_store_mode, Richard Henderson, 2025/05/07
- [PATCH v5 23/24] target/m68k: Make vmstate variables static, Richard Henderson, 2025/05/07
- [PATCH v5 19/24] target/m68k: Merge gen_load_fp, gen_load_mode_fp, Richard Henderson, 2025/05/07
- [PATCH v5 17/24] target/m68k: Split gen_ea_mode_fp for load/store, Richard Henderson, 2025/05/07
- [PATCH v5 24/24] target/m68k: Implement FPIAR, Richard Henderson, 2025/05/07