[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 13/19] hw/block/fdc-isa: Remove 'fallback' property
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v4 13/19] hw/block/fdc-isa: Remove 'fallback' property |
Date: |
Mon, 12 May 2025 10:39:42 +0200 |
The "fallback" property was only used by the hw_compat_2_5[] array,
as 'fallback=144'. We removed all machines using that array, lets
remove ISA floppy drive 'fallback' property, manually setting the
default value in isabus_fdc_realize().
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
---
hw/block/fdc-isa.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/block/fdc-isa.c b/hw/block/fdc-isa.c
index 6d1790e0e61..5d746d73165 100644
--- a/hw/block/fdc-isa.c
+++ b/hw/block/fdc-isa.c
@@ -97,6 +97,7 @@ static void isabus_fdc_realize(DeviceState *dev, Error **errp)
isa->iobase, fdc_portio_list, fdctrl,
"fdc");
+ fdctrl->fallback = FLOPPY_DRIVE_TYPE_288;
fdctrl->irq = isa_bus_get_irq(bus, isa->irq);
fdctrl->dma_chann = isa->dma;
if (fdctrl->dma_chann != -1) {
@@ -293,9 +294,6 @@ static const Property isa_fdc_properties[] = {
DEFINE_PROP_SIGNED("fdtypeB", FDCtrlISABus, state.qdev_for_drives[1].type,
FLOPPY_DRIVE_TYPE_AUTO, qdev_prop_fdc_drive_type,
FloppyDriveType),
- DEFINE_PROP_SIGNED("fallback", FDCtrlISABus, state.fallback,
- FLOPPY_DRIVE_TYPE_288, qdev_prop_fdc_drive_type,
- FloppyDriveType),
};
static void isabus_fdc_class_init(ObjectClass *klass, const void *data)
--
2.47.1
- [PATCH v4 05/19] hw/core/machine: Remove hw_compat_2_4[] array, (continued)
- [PATCH v4 05/19] hw/core/machine: Remove hw_compat_2_4[] array, Philippe Mathieu-Daudé, 2025/05/12
- [PATCH v4 12/19] hw/core/machine: Remove hw_compat_2_5[] array, Philippe Mathieu-Daudé, 2025/05/12
- [PATCH v4 07/19] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_MIGRATE_EXTRA definition, Philippe Mathieu-Daudé, 2025/05/12
- [PATCH v4 09/19] hw/i386/pc: Remove deprecated pc-q35-2.5 and pc-i440fx-2.5 machines, Philippe Mathieu-Daudé, 2025/05/12
- [PATCH v4 14/19] hw/scsi/vmw_pvscsi: Remove PVSCSI_COMPAT_OLD_PCI_CONFIGURATION definition, Philippe Mathieu-Daudé, 2025/05/12
- [PATCH v4 10/19] hw/i386/x86: Remove X86MachineClass::save_tsc_khz field, Philippe Mathieu-Daudé, 2025/05/12
- [PATCH v4 08/19] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_DISABLE_PCIE definition, Philippe Mathieu-Daudé, 2025/05/12
- [PATCH v4 11/19] hw/nvram/fw_cfg: Remove legacy FW_CFG_ORDER_OVERRIDE, Philippe Mathieu-Daudé, 2025/05/12
- [PATCH v4 17/19] hw/net/vmxnet3: Remove VMXNET3_COMPAT_FLAG_OLD_MSI_OFFSETS definition, Philippe Mathieu-Daudé, 2025/05/12
- [PATCH v4 16/19] hw/scsi/vmw_pvscsi: Convert DeviceRealize -> InstanceInit, Philippe Mathieu-Daudé, 2025/05/12
- [PATCH v4 13/19] hw/block/fdc-isa: Remove 'fallback' property,
Philippe Mathieu-Daudé <=
- [PATCH v4 15/19] hw/scsi/vmw_pvscsi: Remove PVSCSI_COMPAT_DISABLE_PCIE_BIT definition, Philippe Mathieu-Daudé, 2025/05/12
- [PATCH v4 18/19] hw/net/vmxnet3: Remove VMXNET3_COMPAT_FLAG_DISABLE_PCIE definition, Philippe Mathieu-Daudé, 2025/05/12
- [PATCH v4 19/19] hw/net/vmxnet3: Merge DeviceRealize in InstanceInit, Philippe Mathieu-Daudé, 2025/05/12