Re: [PATCH 08/27] qemu-img: simplify --repair error message

[Kevin Wolf]

Am 27.09.2024 um 08:11 hat Michael Tokarev geschrieben:
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  qemu-img.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-img.c b/qemu-img.c
> index 1bd88fcf63..9157a6b45d 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -859,8 +859,9 @@ static int img_check(const img_cmd_t *ccmd, int argc, 
> char **argv)
>              } else if (!strcmp(optarg, "all")) {
>                  fix = BDRV_FIX_LEAKS | BDRV_FIX_ERRORS;
>              } else {
> -                error_exit(argv[0], "Unknown option value for -r "
> -                           "(expecting 'leaks' or 'all'): %s", optarg);
> +                error_exit(argv[0],
> +                           "--repair (-r) expects 'leaks' or 'all' not '%s'",
> +                           optarg);

Again the comma before "not '%s'". With that added:

Reviewed-by: Kevin Wolf <kwolf@redhat.com>