Re: [PATCH v2] meson.build: Compile hw_common_arch_libs files with right header include paths

[Pierrick Bouvier]

Hi Thomas,

On 5/13/25 4:56 AM, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> Since commit 6f4e8a92bbd ("hw/arm: make most of the compilation units
> common"), compilation of some arm machines (like musicpal) fails on
> certain host systems like OpenBSD 7.6/7.7 since headers like <epoxy/gl.h>
> don't reside in /usr/include and we currently don't add the right
> CFLAGS for the common files to include the additional header search
> paths. Add a loop similar to what we already did in commit 727bb5b477e6
> to fix it.
>
> With this fix applied, we can now also drop the explicit dependency
> on pixman for the arm musicpal machine.
>
> Fixes: 6f4e8a92bbd ("hw/arm: make most of the compilation units common")
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> [thuth: Add commit message + changes in hw/arm/meson.build]
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   v2: Change the subject of the patch according to Paolo's suggestion
>
>   meson.build        | 27 ++++++++++++++++-----------
>   hw/arm/meson.build |  2 +-
>   2 files changed, 17 insertions(+), 12 deletions(-)


Thanks for the patch.
I didn't run into any issue when building for {linux, macos, windows, 
freebsd}, so I assumed it was safe to do things this way and specific 
dependencies could just be listed with associated sources.
It seems like there are cracks in this approach, so adding all the 
dependencies per base arch is a good idea.

Any chance you could base it on this commit [1] (and add it for new 
libraries as well)?

This is going to be pulled very shortly (as part of a wider series), and 
the same fix will be needed.

[1] 20250512180502.2395029-4-pierrick.bouvier@linaro.org

Thanks,
Pierrick