Re: [PATCH 09/13] qapi: transform target specific 'if' in runtime checks

[Markus Armbruster]

Fails to build:

        /usr/bin/ld: 
libqemu-x86_64-softmmu.a.p/meson-generated_.._qapi_qapi-commands-machine-target.c.o:
 in function `qmp_marshal_query_cpu_model_comparison':
        
/work/armbru/qemu/bld-x86/qapi/qapi-commands-machine-target.c:66:(.text+0x10c9):
 undefined reference to `qmp_query_cpu_model_comparison'
        /usr/bin/ld: 
libqemu-x86_64-softmmu.a.p/meson-generated_.._qapi_qapi-commands-machine-target.c.o:
 in function `qmp_marshal_query_cpu_model_baseline':
        
/work/armbru/qemu/bld-x86/qapi/qapi-commands-machine-target.c:131:(.text+0x143c):
 undefined reference to `qmp_query_cpu_model_baseline'
        /usr/bin/ld: 
libqemu-x86_64-softmmu.a.p/meson-generated_.._qapi_qapi-commands-machine-target.c.o:
 in function `qmp_marshal_set_cpu_topology':
        
/work/armbru/qemu/bld-x86/qapi/qapi-commands-machine-target.c:306:(.text+0x1de1):
 undefined reference to `qmp_set_cpu_topology'
        /usr/bin/ld: 
libqemu-x86_64-softmmu.a.p/meson-generated_.._qapi_qapi-commands-machine-target.c.o:
 in function `qmp_marshal_query_s390x_cpu_polarization':
        
/work/armbru/qemu/bld-x86/qapi/qapi-commands-machine-target.c:362:(.text+0x20c6):
 undefined reference to `qmp_query_s390x_cpu_polarization'
        /usr/bin/ld: 
libqemu-x86_64-softmmu.a.p/meson-generated_.._qapi_qapi-commands-misc-target.c.o:
 in function `qmp_marshal_query_gic_capabilities':
        
/work/armbru/qemu/bld-x86/qapi/qapi-commands-misc-target.c:393:(.text+0x2d2d): 
undefined reference to `qmp_query_gic_capabilities'
        collect2: error: ld returned 1 exit status

The next commit fixes it.  It then fails tests:

    stdout:
    --- /work/armbru/qemu/bld-x86/../tests/qapi-schema/unknown-expr-key.err
    +++ 
    @@ -1,3 +1,3 @@
     unknown-expr-key.json: In struct 'Bar':
     unknown-expr-key.json:2: struct has unknown keys 'bogus', 'phony'
    -Valid keys are 'base', 'data', 'features', 'if', 'struct'.
    +Valid keys are 'base', 'data', 'features', 'if', 'runtime_if', 'struct'.
    stderr:
    unknown-expr-key FAIL

Fixup:

diff --git a/tests/qapi-schema/unknown-expr-key.err 
b/tests/qapi-schema/unknown-expr-key.err
index f2538e3ce7..8184f3c768 100644
--- a/tests/qapi-schema/unknown-expr-key.err
+++ b/tests/qapi-schema/unknown-expr-key.err
@@ -1,3 +1,3 @@
 unknown-expr-key.json: In struct 'Bar':
 unknown-expr-key.json:2: struct has unknown keys 'bogus', 'phony'
-Valid keys are 'base', 'data', 'features', 'if', 'struct'.
+Valid keys are 'base', 'data', 'features', 'if', 'runtime_if', 'struct'.