Re: [PATCH v2 03/20] mcd: Introduce MCD server

[Daniel P . Berrangé]

On Wed, Apr 30, 2025 at 07:27:24AM +0200, Mario Fleischmann wrote:
> The MCD implementation follows a remote procedure call approach
> and will use a client JSON protocol for communication.
> 
> While the MCD server implements the MCD API, the server stub will be
> responsible for handling the JSON connection and for dispatching the
> corresponding server functions.
> 
> Signed-off-by: Mario Fleischmann <mario.fleischmann@lauterbach.com>
> ---
>  mcd/mcd_server.c | 431 +++++++++++++++++++++++++++++++++++++++++++++++
>  mcd/meson.build  |  14 ++
>  meson.build      |   4 +
>  3 files changed, 449 insertions(+)
>  create mode 100644 mcd/mcd_server.c
>  create mode 100644 mcd/meson.build
> 
> diff --git a/mcd/mcd_server.c b/mcd/mcd_server.c
> new file mode 100644
> index 0000000..a20708d
> --- /dev/null
> +++ b/mcd/mcd_server.c
> @@ -0,0 +1,431 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/*
> + * mcdserver - Multi-Core Debug (MCD) API implementation

Nitpick - you don't need to open & close a comment just for the
SPDX tag, just let the whole header flow as one comment

> + *
> + * Copyright (c) 2025 Lauterbach GmbH
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.

This text should be omitted in any new files - only the SPDX
tag is expected/required.

I won't repeat them on later patches, but these comments apply
to all new files through this whole series.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|