Re: [PATCH 3/4] hw/microblaze: Remove the big-endian variants of ml605 and xlnx-zynqmp-pmu

[Thomas Huth]

On 16/05/2025 17.00, Philippe Mathieu-Daudé wrote:
> On 15/5/25 15:20, Thomas Huth wrote:
> > From: Thomas Huth <thuth@redhat.com>
> >
> > Both machines were added with little-endian in mind only (the
> > "endianness" CPU property was hard-wired to "true", see commits
> > 133d23b3ad1 and a88bbb006a52), so the variants that showed up
> > on the big endian target likely never worked. We deprecated these
> > non-working machine variants two releases ago, and so far nobody
> > complained, so it should be fine now to disable them. Hard-wire
> > the machines to little endian now.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >   docs/about/deprecated.rst           |  6 ------
> >   docs/about/removed-features.rst     |  9 +++++++++
> >   hw/microblaze/petalogix_ml605_mmu.c | 15 ++++-----------
> >   hw/microblaze/xlnx-zynqmp-pmu.c     |  7 +------
> >   4 files changed, 14 insertions(+), 23 deletions(-)
>
> \o/
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thanks!

> I won't be able to look at the rest of this series until in 10 days,
> feel free to merge if necessary.

Maybe you could at least provide a quick comment on the idea of controlling 
the endianness of the s3adsp1800 machine via a machine property? (since your 
original idea was to do it via different machine names instead ... does the 
property sound acceptable to you?)

 Thomas