[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 00/10] Drop code for non-qdevified ID
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 00/10] Drop code for non-qdevified IDE, and clean up |
Date: |
Tue, 18 Dec 2012 16:10:41 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Anthony Liguori <address@hidden> writes:
> Markus Armbruster <address@hidden> writes:
>
>> *** Important ***
>> This *breaks* all non-qdevified controllers, see PATCH 01/10.
>> Maintainers are cc'ed.
>>
>> If you want still more time to qdevify your controller, please speak
>> up now, and tell us how much.
>>
>> The rest of the series is obvious cleanups enabled by dropping the
>> special case of a non-qdevified controller. The block configuration
>> stuff I'm working on also profits from it, and is real reason I'm
>> posting this.
>
> Breaking is not the right approach. If you're asserting that the code
> is unused and unloved, then remove it entirely from the tree.
Can do.
> Just breaking something is always wrong though.
>
> I only see three users of ide_init2_with_non_qdev_drives. Is there any
> reason you didn't just convert these users to qdev?
Yes: it's more work than I can do on the side.
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers, (continued)
- [Qemu-ppc] [PATCH 03/10] ide: Use IDEState member dev for "device connected" test, Markus Armbruster, 2012/12/17
- [Qemu-ppc] [PATCH 10/10] ide: Drop redundant IDEState member wwn, Markus Armbruster, 2012/12/17
- [Qemu-ppc] [PATCH 07/10] ide: Drop redundant IDEState member version, Markus Armbruster, 2012/12/17
- [Qemu-ppc] [PATCH 06/10] ide: Drop redundant IDEState geometry members, Markus Armbruster, 2012/12/17
- [Qemu-ppc] [PATCH 09/10] ide: Drop redundant IDEState member model, Markus Armbruster, 2012/12/17
- [Qemu-ppc] [PATCH 04/10] ide: Don't block-align IDEState member smart_selftest_data, Markus Armbruster, 2012/12/17
- [Qemu-ppc] [PATCH 08/10] ide: Drop redundant IDEState member drive_serial_str, Markus Armbruster, 2012/12/17
- [Qemu-ppc] [PATCH 05/10] ide: Drop redundant IDEState member bs, Markus Armbruster, 2012/12/17
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 00/10] Drop code for non-qdevified IDE, and clean up, Anthony Liguori, 2012/12/18
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 00/10] Drop code for non-qdevified IDE, and clean up,
Markus Armbruster <=