[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PULL 02/18] pseries: Fix stalls on hypervisor virtual consol
From: |
Alexander Graf |
Subject: |
[Qemu-ppc] [PULL 02/18] pseries: Fix stalls on hypervisor virtual console |
Date: |
Mon, 2 Sep 2013 10:11:17 +0200 |
From: Anton Blanchard <address@hidden>
A number of users are reporting stalls when using the pseries
hypervisor virtual console.
A simple test case is to paste 15 or 17 characters at a time
into the console. Pasting 15 characters at a time works fine
but pasting 17 characters hangs for a random amount of time.
Other activity (network, qemu monitor etc) unblocks it.
If qemu-char tries to send more than 16 characters at once,
vty_can_receive returns false. At this point we have to
wait for the guest to consume that output. Everything is good
so far.
The problem occurs when the the guest does consume the output.
We need to signal back to the qemu-char layer that we are
ready for more input. Without this we block until something
else kicks us (eg network activity).
Signed-off-by: Anton Blanchard <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>
---
hw/char/spapr_vty.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/char/spapr_vty.c b/hw/char/spapr_vty.c
index a799721..9c2aef8 100644
--- a/hw/char/spapr_vty.c
+++ b/hw/char/spapr_vty.c
@@ -47,6 +47,8 @@ static int vty_getchars(VIOsPAPRDevice *sdev, uint8_t *buf,
int max)
buf[n++] = dev->buf[dev->out++ % VTERM_BUFSIZE];
}
+ qemu_chr_accept_input(dev->chardev);
+
return n;
}
--
1.8.1.4
- [Qemu-ppc] [PULL 00/18] ppc patch queue 2013-09-02, Alexander Graf, 2013/09/02
- [Qemu-ppc] [PULL 10/18] target-ppc: fix bit extraction for FPBF and FPL, Alexander Graf, 2013/09/02
- [Qemu-ppc] [PULL 15/18] pseries: Add H_SET_MODE hcall to change guest exception endianness, Alexander Graf, 2013/09/02
- [Qemu-ppc] [PULL 05/18] disas/ppc.c: Fix little endian disassembly, Alexander Graf, 2013/09/02
- [Qemu-ppc] [PULL 06/18] ppc: virtex_ml507: QEMU_OPTION_dtb support for this machine., Alexander Graf, 2013/09/02
- [Qemu-ppc] [PULL 02/18] pseries: Fix stalls on hypervisor virtual console,
Alexander Graf <=
- [Qemu-ppc] [PULL 07/18] ppc405_boards: Disable debug output, Alexander Graf, 2013/09/02
- [Qemu-ppc] [PULL 08/18] ppc405_uc: Disable debug output, Alexander Graf, 2013/09/02
- [Qemu-ppc] [PULL 03/18] target-ppc: USE LPCR_ILE to control exception endian on POWER7, Alexander Graf, 2013/09/02
- [Qemu-ppc] [PULL 01/18] PPC: E500: Generate device tree on reset, Alexander Graf, 2013/09/02
- [Qemu-ppc] [PULL 04/18] target-ppc: POWER7 supports the MSR_LE bit, Alexander Graf, 2013/09/02
- [Qemu-ppc] [PULL 14/18] xics: move registration of global state to realize(), Alexander Graf, 2013/09/02
- [Qemu-ppc] [PULL 16/18] PPC: KVM: Compile fix for qemu_notify_event, Alexander Graf, 2013/09/02
- [Qemu-ppc] [PULL 17/18] spapr: add "stop-self" RTAS call required to support hot CPU unplug, Alexander Graf, 2013/09/02
- [Qemu-ppc] [PULL 11/18] spapr-pci: fix config space access to support bridges, Alexander Graf, 2013/09/02
- [Qemu-ppc] [PULL 09/18] ppc405_boards: Don't enforce presence of firmware for qtest, Alexander Graf, 2013/09/02