[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] PPC: fix PCI configuration space MemoryRegions fo
|
From: |
Alexander Graf |
|
Subject: |
Re: [Qemu-ppc] [PATCH] PPC: fix PCI configuration space MemoryRegions for grackle/uninorth |
|
Date: |
Fri, 11 Oct 2013 11:32:41 +0200 |
On 11.10.2013, at 01:00, Mark Cave-Ayland <address@hidden> wrote:
> OpenBIOS prior to SVN r1225 had a horrible bug when accessing PCI
> configuration space for PPC Mac architectures - instead of writing the PCI
> configuration data value to the data register address, it would instead write
> it to the data register address plus the PCI configuration address.
>
> For this reason, the MemoryRegions for the PCI data register for
> grackle/uninorth were extremely large in order to accomodate the entire PCI
> configuration space being accessed during OpenBIOS PCI bus enumeration. Now
> that the OpenBIOS images have been updated, reduce the MemoryRegion sizes down
> to a single 32-bit register as intended.
>
> Signed-off-by: Mark Cave-Ayland <address@hidden>
The patch looks perfectly good to me. I checked that there really is only one
register for config/data at least in MCP750 which is the closest to a Grackle
spec that I have.
However, I'm not allowed to apply patches that were not posted on qemu-devel
for the public to review. Could you please repost and CC the list? :)
Thanks!
Alex