[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH v4 6/7] raven: fix PCI bus accesses w
From: |
Artyom Tarasenko |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH v4 6/7] raven: fix PCI bus accesses with size > 1 |
Date: |
Tue, 18 Mar 2014 10:23:08 +0100 |
On Mon, Mar 17, 2014 at 11:00 PM, Hervé Poussineau <address@hidden> wrote:
> Signed-off-by: Hervé Poussineau <address@hidden>
Reviewed-by: Artyom Tarasenko <address@hidden>
> ---
> hw/pci-host/prep.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c
> index 8d0794e..fed6c26 100644
> --- a/hw/pci-host/prep.c
> +++ b/hw/pci-host/prep.c
> @@ -223,12 +223,12 @@ static void raven_pcihost_realizefn(DeviceState *d,
> Error **errp)
>
> pci_bus_irqs(&s->pci_bus, prep_set_irq, prep_map_irq, s->irq,
> PCI_NUM_PINS);
>
> - memory_region_init_io(&h->conf_mem, OBJECT(h), &pci_host_conf_be_ops, s,
> - "pci-conf-idx", 1);
> + memory_region_init_io(&h->conf_mem, OBJECT(h), &pci_host_conf_le_ops, s,
> + "pci-conf-idx", 4);
> memory_region_add_subregion(&s->pci_io, 0xcf8, &h->conf_mem);
>
> - memory_region_init_io(&h->data_mem, OBJECT(h), &pci_host_data_be_ops, s,
> - "pci-conf-data", 1);
> + memory_region_init_io(&h->data_mem, OBJECT(h), &pci_host_data_le_ops, s,
> + "pci-conf-data", 4);
> memory_region_add_subregion(&s->pci_io, 0xcfc, &h->data_mem);
>
> memory_region_init_io(&h->mmcfg, OBJECT(s), &PPC_PCIIO_ops, s, "pciio",
> 0x00400000);
> --
> 1.7.10.4
>
>
--
Regards,
Artyom Tarasenko
linux/sparc and solaris/sparc under qemu blog:
http://tyom.blogspot.com/search/label/qemu
- [Qemu-ppc] [PATCH v4 0/7] prep: improve Raven PCI host emulation, Hervé Poussineau, 2014/03/17
- [Qemu-ppc] [PATCH v4 2/7] raven: implement non-contiguous I/O region, Hervé Poussineau, 2014/03/17
- [Qemu-ppc] [PATCH v4 1/7] raven: rename intack region to pci_intack, Hervé Poussineau, 2014/03/17
- [Qemu-ppc] [PATCH v4 3/7] raven: set a correct PCI I/O memory region, Hervé Poussineau, 2014/03/17
- [Qemu-ppc] [PATCH v4 4/7] raven: set a correct PCI memory region, Hervé Poussineau, 2014/03/17
- [Qemu-ppc] [PATCH v4 5/7] raven: add PCI bus mastering address space, Hervé Poussineau, 2014/03/17
- [Qemu-ppc] [PATCH v4 6/7] raven: fix PCI bus accesses with size > 1, Hervé Poussineau, 2014/03/17
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v4 6/7] raven: fix PCI bus accesses with size > 1,
Artyom Tarasenko <=
- [Qemu-ppc] [PATCH v4 7/7] raven: use raven_ for all function prefixes, Hervé Poussineau, 2014/03/17