Re: [Qemu-ppc] [PATCH RFC] openbios-devel/arch/ppc/qemu/init.c

[Alexander Graf]

On 17.04.14 11:52, BALATON Zoltan wrote:
> On Wed, 16 Apr 2014, Alexander Graf wrote:
> > Ah, it was the clock frequency vs tb frequency. Jeez - we have way 
> > too many of these.
> >
> > Yes, please add it as a value in fw_cfg.
>
> This is what's in qemu/include/hw/ppc/ppc.h:
>
> #define FW_CFG_PPC_WIDTH        (FW_CFG_ARCH_LOCAL + 0x00)
> #define FW_CFG_PPC_HEIGHT       (FW_CFG_ARCH_LOCAL + 0x01)
> #define FW_CFG_PPC_DEPTH        (FW_CFG_ARCH_LOCAL + 0x02)
> #define FW_CFG_PPC_TBFREQ       (FW_CFG_ARCH_LOCAL + 0x03)
> #define FW_CFG_PPC_CLOCKFREQ    (FW_CFG_ARCH_LOCAL + 0x04)
> #define FW_CFG_PPC_IS_KVM       (FW_CFG_ARCH_LOCAL + 0x05)
> #define FW_CFG_PPC_KVM_HC       (FW_CFG_ARCH_LOCAL + 0x06)
> #define FW_CFG_PPC_KVM_PID      (FW_CFG_ARCH_LOCAL + 0x07)
>
> And this is what's in openbios-devel/include/arch/common/fw_cfg.h:
>
> #define FW_CFG_PPC_WIDTH        (FW_CFG_ARCH_LOCAL + 0x00)
> #define FW_CFG_PPC_HEIGHT       (FW_CFG_ARCH_LOCAL + 0x01)
> #define FW_CFG_PPC_DEPTH        (FW_CFG_ARCH_LOCAL + 0x02)
> #define FW_CFG_PPC_TBFREQ       (FW_CFG_ARCH_LOCAL + 0x03)
> #define FW_CFG_PPC_CLOCKFREQ    (FW_CFG_ARCH_LOCAL + 0x04)
> #define FW_CFG_PPC_IS_KVM       (FW_CFG_ARCH_LOCAL + 0x05)
> #define FW_CFG_PPC_KVM_HC       (FW_CFG_ARCH_LOCAL + 0x06)
> #define FW_CFG_PPC_KVM_PID      (FW_CFG_ARCH_LOCAL + 0x07)
> #define FW_CFG_PPC_NVRAM_ADDR   (FW_CFG_ARCH_LOCAL + 0x08)
>
> Should I add new FW_CFG values with a gap (or adding an unused 
> FW_CFG_PPC_NVRAM_ADDR to qemu) or should I renumber these ti add 
> FW_CFG_PPC_BUSFREQ grouped with the other FREQ values?

Just add BUSFREQ as 0x09 in both and leave a gap in QEMU's fw_cfg header.


Alex