[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 07/10] pseries: Clean up error handli
From: |
Eric Blake |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 07/10] pseries: Clean up error handling in spapr_rtas_register() |
Date: |
Tue, 19 Jan 2016 15:58:46 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 01/15/2016 05:00 AM, David Gibson wrote:
> The errors detected in this function necessarily indicate bugs in the rest
> of the qemu code, rather than an external or configuration problem.
>
> So, a simple assert() is more appropriate than any more complex error
> reporting.
>
> Signed-off-by: David Gibson <address@hidden>
> ---
> hw/ppc/spapr_rtas.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c
> index 34b12a3..0be52ae 100644
> --- a/hw/ppc/spapr_rtas.c
> +++ b/hw/ppc/spapr_rtas.c
> @@ -648,17 +648,11 @@ target_ulong spapr_rtas_call(PowerPCCPU *cpu,
> sPAPRMachineState *spapr,
>
> void spapr_rtas_register(int token, const char *name, spapr_rtas_fn fn)
> {
> - if (!((token >= RTAS_TOKEN_BASE) && (token < RTAS_TOKEN_MAX))) {
> - fprintf(stderr, "RTAS invalid token 0x%x\n", token);
> - exit(1);
> - }
> + assert((token >= RTAS_TOKEN_BASE) && (token < RTAS_TOKEN_MAX));
You could drop the redundant () while touching this, as in:
assert(token >= RTAS_TOKEN_BASE && token < RTAS_TOKEN_MAX);
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-ppc] [PATCH 04/10] pseries: Clean up error handling in spapr_validate_node_memory(), (continued)
- [Qemu-ppc] [PATCH 04/10] pseries: Clean up error handling in spapr_validate_node_memory(), David Gibson, 2016/01/15
- [Qemu-ppc] [PATCH 08/10] pseries: Clean up error handling in xics_system_init(), David Gibson, 2016/01/15
- [Qemu-ppc] [PATCH 03/10] pseries: Clean up hash page table allocation error handling, David Gibson, 2016/01/15
- Re: [Qemu-ppc] [PATCH 03/10] pseries: Clean up hash page table allocation error handling, Alexey Kardashevskiy, 2016/01/17
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 03/10] pseries: Clean up hash page table allocation error handling, David Gibson, 2016/01/17
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 03/10] pseries: Clean up hash page table allocation error handling, Alexey Kardashevskiy, 2016/01/18
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 03/10] pseries: Clean up hash page table allocation error handling, David Gibson, 2016/01/18
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 03/10] pseries: Clean up hash page table allocation error handling, Alexey Kardashevskiy, 2016/01/18
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 03/10] pseries: Clean up hash page table allocation error handling, David Gibson, 2016/01/18
[Qemu-ppc] [PATCH 07/10] pseries: Clean up error handling in spapr_rtas_register(), David Gibson, 2016/01/15
[Qemu-ppc] [PATCH 10/10] pseries: Clean up error reporting in htab migration functions, David Gibson, 2016/01/15
[Qemu-ppc] [PATCH 05/10] pseries: Cleanup error handling in spapr_vga_init(), David Gibson, 2016/01/15
[Qemu-ppc] [PATCH 06/10] pseries: Improve error handling in find_unknown_sysbus_device(), David Gibson, 2016/01/15