[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [1/3] powerpc: scan_features() updates incorrect bits
|
From: |
Michael Ellerman |
|
Subject: |
Re: [Qemu-ppc] [1/3] powerpc: scan_features() updates incorrect bits |
|
Date: |
Mon, 18 Apr 2016 14:40:45 +1000 |
On Sat, 2016-04-16 at 00:27 +1000, Michael Ellerman wrote:
> On Fri, 2016-15-04 at 02:06:13 UTC, Unknown sender due to SPF wrote:
> > The real LE feature entry in the ibm_pa_feature struct has the
> > wrong number of elements. Instead of checking for byte 5, bit 0,
> > we check for byte 0, bit 0, and we also incorrectly update cpu user
> > feature bit 5.
>
> Finally the user feature, we're setting 5, ie. 0x4 | 0x1, which is:
>
> #define PPC_FEATURE_PPC_LE 0x00000001
>
> And nothing else, 0x4 is free.
Buuuut, we should reserve 0x4 for the foreseeable future. Because it is
erroneously set on older kernels.
cheers
- Re: [Qemu-ppc] [PATCH] spapr: Don't set the TM ibm, pa-features bit in PR KVM mode, (continued)
[Qemu-ppc] [PATCH] powerpc: Clear user CPU feature bits if TM is disabled at runtime, Anton Blanchard, 2016/04/04
[Qemu-ppc] [PATCH 1/3] powerpc: scan_features() updates incorrect bits, Anton Blanchard, 2016/04/14
Re: [Qemu-ppc] [1/3] powerpc: scan_features() updates incorrect bits, Michael Ellerman, 2016/04/18
[Qemu-ppc] [PATCH v2 1/3] powerpc: scan_features() updates incorrect bits for REAL_LE, Michael Ellerman, 2016/04/18
Re: [Qemu-ppc] [v2, 1/3] powerpc: scan_features() updates incorrect bits for REAL_LE, Michael Ellerman, 2016/04/19
[Qemu-ppc] [PATCH 2/3] powerpc: Update cpu_user_features2 in scan_features(), Anton Blanchard, 2016/04/14
[Qemu-ppc] [PATCH 3/3] powerpc: Update TM user feature bits in scan_features(), Anton Blanchard, 2016/04/14