[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 13/32] ppc: Don't update NIP in lswi/lswx/stswi/st
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-ppc] [PATCH 13/32] ppc: Don't update NIP in lswi/lswx/stswi/stswx |
Date: |
Wed, 27 Jul 2016 13:51:41 +1000 |
On Wed, 2016-07-27 at 12:04 +1000, David Gibson wrote:
> On Wed, Jul 27, 2016 at 08:21:07AM +1000, Benjamin Herrenschmidt
> wrote:
> > Instead, pass GETPC() result to the corresponding helpers. This
> > requires a bit of fiddling to get the PC (hopefully) right in
> > the case where we generate a program check, though the hacks there
> > are temporary, a subsequent patch will clean this all up by always
> > having the nip already set to the right instruction when taking
> > the fault.
>
> Where are cpu_ldub_data() and cpu_ldub_data_ra() defined? I assume
> it's via macro somewhere, since I couldn't find it with a grep.
Yeah all that stuff is defined via macros in
include/exec/cpu_ldst.h and cpu_ldst_template.h
- [Qemu-ppc] [PATCH 01/32] ppc: Fix fault PC reporting for lve*/stve* VMX instructions, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-ppc] [PATCH 02/32] ppc: Provide basic raise_exception_* functions, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-ppc] [PATCH 05/32] ppc: Move DFP ops out of translate.c, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-ppc] [PATCH 09/32] ppc: Make float_invalid_op_excp() pass the return address, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-ppc] [PATCH 15/32] ppc: Make tlb_fill() use new exception helper, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-ppc] [PATCH 13/32] ppc: Don't update NIP in lswi/lswx/stswi/stswx, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-ppc] [PATCH 10/32] ppc: Make float_check_status() pass the return address, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-ppc] [PATCH 12/32] ppc: FP exceptions are always precise, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-ppc] [PATCH 11/32] ppc: Don't update the NIP in floating point generated code, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-ppc] [PATCH 08/32] ppc: Rename fload_invalid_op_excp to float_invalid_op_excp, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-ppc] [PATCH 03/32] ppc: Move classic fp ops out of translate.c, Benjamin Herrenschmidt, 2016/07/26