Re: [Qemu-ppc] [PATCH 0/4] tests: enable ohci/uhci/xhci tests on PPC64

[David Gibson]

On Mon, Sep 26, 2016 at 04:10:45PM +0200, Laurent Vivier wrote:
> This series enables USB tests on PPC64, and for
> that implements libqos SPAPR PCI support.

I have a few comments on various patches in the series, but overall it
looks like a good idea.

Anyone have any objection to me taking this through my tree once the
nits are removed?

> 
> Laurent Vivier (4):
>   libqos: add PPC64 PCI support
>   libqos: add PCI management in qtest_vboot()/qtest_shutdown()
>   libqos: use generic qtest_shutdown()
>   tests: enable ohci/uhci/xhci tests on PPC64
> 
>  tests/Makefile.include      |   9 +-
>  tests/e1000e-test.c         |   2 +-
>  tests/i440fx-test.c         |   2 +-
>  tests/ide-test.c            |   2 +-
>  tests/ivshmem-test.c        |   2 +-
>  tests/libqos/ahci.c         |   2 +-
>  tests/libqos/libqos-pc.c    |   8 +-
>  tests/libqos/libqos-spapr.c |   8 +-
>  tests/libqos/libqos.c       |  32 ++++-
>  tests/libqos/libqos.h       |  11 +-
>  tests/libqos/pci-pc.c       |  24 +---
>  tests/libqos/pci-pc.h       |   3 +-
>  tests/libqos/pci-spapr.c    | 280 
> ++++++++++++++++++++++++++++++++++++++++++++
>  tests/libqos/pci-spapr.h    |  17 +++
>  tests/libqos/pci.c          |  22 +++-
>  tests/libqos/rtas.c         |  45 +++++++
>  tests/libqos/rtas.h         |   4 +
>  tests/libqos/usb.c          |  14 +++
>  tests/q35-test.c            |   2 +-
>  tests/rtas-test.c           |   2 +-
>  tests/rtl8139-test.c        |   2 +-
>  tests/tco-test.c            |   2 +-
>  tests/usb-hcd-ehci-test.c   |   2 +-
>  tests/usb-hcd-uhci-test.c   |  24 ++--
>  tests/vhost-user-test.c     |   2 +-
>  tests/virtio-9p-test.c      |   2 +-
>  tests/virtio-blk-test.c     |   2 +-
>  tests/virtio-net-test.c     |   2 +-
>  tests/virtio-scsi-test.c    |   2 +-
>  29 files changed, 470 insertions(+), 61 deletions(-)
>  create mode 100644 tests/libqos/pci-spapr.c
>  create mode 100644 tests/libqos/pci-spapr.h
> 

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature